Skip to content

Commit a140e99

Browse files
removed redundant component creation
1 parent 0b9adc4 commit a140e99

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3870,17 +3870,9 @@ def create_config_components_resolver(
38703870
def create_parametrized_components_resolver(
38713871
self, model: ParametrizedComponentsResolverModel, config: Config
38723872
) -> ParametrizedComponentsResolver:
3873-
updated_stream_parameters = []
3874-
for stream_parameters in model.stream_parameters.lisf_of_parameters_for_stream:
3875-
try:
3876-
stream_parameters = self._create_component_from_model(
3877-
stream_parameters, config=config, parameters=model.parameters or {}
3878-
)
3879-
except ValueError as ex: # when an object doesn't have a type, we leave it as is
3880-
pass
3881-
updated_stream_parameters.append(stream_parameters)
3882-
3883-
model.stream_parameters.lisf_of_parameters_for_stream = updated_stream_parameters
3873+
stream_parameters = StreamParametersDefinition(
3874+
lisf_of_parameters_for_stream=model.stream_parameters.lisf_of_parameters_for_stream
3875+
)
38843876
components_mapping = [
38853877
self._create_component_from_model(
38863878
model=components_mapping_definition_model,
@@ -3892,7 +3884,7 @@ def create_parametrized_components_resolver(
38923884
for components_mapping_definition_model in model.components_mapping
38933885
]
38943886
return ParametrizedComponentsResolver(
3895-
stream_parameters=model.stream_parameters,
3887+
stream_parameters=stream_parameters,
38963888
config=config,
38973889
components_mapping=components_mapping,
38983890
parameters=model.parameters or {},

0 commit comments

Comments
 (0)