add comment about removing generics

brianjlai · brianjlai · commit a7384b79845b · 2025-08-26T09:30:15.000-07:00
diff --git a/airbyte_cdk/sources/declarative/concurrent_declarative_source.py b/airbyte_cdk/sources/declarative/concurrent_declarative_source.py
@@ -160,6 +160,8 @@ def _get_declarative_component_schema() -> Dict[str, Any]:
 #
 # todo: The `ConcurrentDeclarativeSource.message_repository()` method can also be removed once AbstractSource
 #  is no longer inherited from since the only external dependency is from that class.
+#
+# todo: It is worth investigating removal of the Generic[TState] since it will always be Optional[List[AirbyteStateMessage]]
 class ConcurrentDeclarativeSource(AbstractSource, Generic[TState]):
     # By default, we defer to a value of 2. A value lower than could cause a PartitionEnqueuer to be stuck in a state of deadlock
     # because it has hit the limit of futures but not partition reader is consuming them.

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,8 @@ def _get_declarative_component_schema() -> Dict[str, Any]:`
`160`	`160`	`#`
`161`	`161`	# todo: The `ConcurrentDeclarativeSource.message_repository()` method can also be removed once AbstractSource
`162`	`162`	`# is no longer inherited from since the only external dependency is from that class.`
	`163`	`+#`
	`164`	`+# todo: It is worth investigating removal of the Generic[TState] since it will always be Optional[List[AirbyteStateMessage]]`
`163`	`165`	`class ConcurrentDeclarativeSource(AbstractSource, Generic[TState]):`
`164`	`166`	`# By default, we defer to a value of 2. A value lower than could cause a PartitionEnqueuer to be stuck in a state of deadlock`
`165`	`167`	`# because it has hit the limit of futures but not partition reader is consuming them.`