refactor: remove returncode/stderr properties from EntrypointOutput

- Remove completed_process parameter from constructor as requested
- Add @classmethod from_completed_process() factory method
- Remove returncode and stderr properties as they are not needed
- Update callers to use EntrypointOutput.errors for failure detection
- Addresses GitHub PR feedback from @aaronsteers

Co-Authored-By: AJ Steers <[email protected]>

Author: devin-ai-integration[bot]

airbyte_cdk/test/entrypoint_wrapper.py

@@ -69,7 +69,6 @@ def __init__(
         uncaught_exception: Optional[BaseException] = None,
         *,
         message_file: Path | None = None,
-        completed_process: Optional[subprocess.CompletedProcess[str]] = None,
     ) -> None:
         if messages is None and message_file is None:
             raise ValueError("Either messages or message_file must be provided")
@@ -78,7 +77,7 @@ def __init__(
 
         self._messages: list[AirbyteMessage] | None = None
         self._message_file: Path | None = message_file
-        self._completed_process: Optional[subprocess.CompletedProcess[str]] = completed_process
+        self._completed_process: Optional[subprocess.CompletedProcess[str]] = None
         if messages:
             try:
                 self._messages = [self._parse_message(message) for message in messages]
@@ -294,15 +293,17 @@ def is_not_in_logs(self, pattern: str) -> bool:
         """Check if no log message matches the case-insensitive pattern."""
         return not self.is_in_logs(pattern)
 
-    @property
-    def returncode(self) -> int | None:
-        """Return the exit code of the process, if available."""
-        return self._completed_process.returncode if self._completed_process else None
-
-    @property
-    def stderr(self) -> str | None:
-        """Return the stderr output of the process, if available."""
-        return self._completed_process.stderr if self._completed_process else None
+    @classmethod
+    def from_completed_process(
+        cls,
+        completed_process: subprocess.CompletedProcess[str],
+        *,
+        message_file: Path | None = None,
+    ) -> "EntrypointOutput":
+        """Create EntrypointOutput from a completed subprocess with optional message file."""
+        instance = cls(message_file=message_file)
+        instance._completed_process = completed_process
+        return instance
 
 
 def _run_command(

airbyte_cdk/test/standard_tests/docker_base.py

@@ -374,22 +374,18 @@ def test_docker_image_build_and_read(
                 capture_stderr=True,
                 capture_stdout=True,
             )
-            if read_result.returncode != 0:
-                error_messages = (
-                    [
-                        f"Error message: {error.trace.error.message}"
-                        for error in read_result.errors
-                        if error.trace and error.trace.error
-                    ]
-                    if read_result.errors
-                    else ["No error messages found"]
-                )
+            if read_result.errors:
+                error_messages = [
+                    f"Error message: {error.trace.error.message}"
+                    for error in read_result.errors
+                    if error.trace and error.trace.error
+                ]
+                if not error_messages:
+                    error_messages = ["No structured error messages found"]
+
                 raise AssertionError(
                     f"Failed to run `read` command in docker image {connector_image!r}. "
                     "\n-----------------"
-                    f"EXIT CODE: {read_result.returncode}\n"
-                    "STDERR:\n"
-                    f"{read_result.stderr}\n"
                     "ERROR MESSAGES:\n"
                     f"{chr(10).join(error_messages)}\n"
                     "\n-----------------"

airbyte_cdk/utils/docker.py

@@ -436,9 +436,9 @@ def run_docker_command(
 
         stdout_temp_file.close()
 
-        return EntrypointOutput(
+        return EntrypointOutput.from_completed_process(
+            completed_process,
             message_file=stdout_path,
-            completed_process=completed_process,
         )
 
 
@@ -485,9 +485,7 @@ def verify_connector_image(
             logger.error("No spec messages found in output.")
             return False
     except subprocess.CalledProcessError as e:
-        logger.error(
-            f"Image verification failed: {result.stderr if 'result' in locals() else e.stderr}"
-        )
+        logger.error(f"Image verification failed: {e.stderr}")
         return False
 
     return True