Skip to content

Commit b212ed9

Browse files
fix mypy
1 parent 218dabb commit b212ed9

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,17 @@ class SimpleRetriever(Retriever, ComponentConstructor[SimpleRetrieverModel]):
136136
@classmethod
137137
def _should_use_lazy_simple_retriever(
138138
cls,
139-
name: str,
140139
model: SimpleRetrieverModel,
141140
additional_flags: AdditionalFlags,
142141
incremental_sync: Optional[
143142
Union[
144143
IncrementingCountCursorModel, DatetimeBasedCursorModel, CustomIncrementalSyncModel
145144
]
146145
] = None,
146+
name: Optional[str] = None,
147147
) -> bool:
148+
if name is None:
149+
raise ValueError(f"name argument is required to instance a {cls.__name__}")
148150
if (
149151
model.partition_router
150152
and isinstance(model.partition_router, SubstreamPartitionRouterModel)
@@ -386,7 +388,7 @@ def _get_log_formatter(
386388
"parameters": model.parameters or {},
387389
}
388390

389-
if cls._should_use_lazy_simple_retriever(name, model, additional_flags, incremental_sync):
391+
if cls._should_use_lazy_simple_retriever(model, additional_flags, incremental_sync, name):
390392
return resolved_dependencies
391393

392394
resolved_dependencies.update(
@@ -420,10 +422,10 @@ def build(
420422
**kwargs,
421423
)
422424
if cls._should_use_lazy_simple_retriever(
423-
name=kwargs.get("name"),
424425
model=model,
425426
additional_flags=additional_flags,
426427
incremental_sync=kwargs.get("incremental_sync"),
428+
name=kwargs.get("name"),
427429
):
428430
return LazySimpleRetriever(**resolved_dependencies)
429431
return SimpleRetriever(**resolved_dependencies)

0 commit comments

Comments
 (0)