Skip to content

Commit b218f3a

Browse files
committed
Update unit test for StateDelegatingRetriever
1 parent 9af489d commit b218f3a

File tree

6 files changed

+895
-1167
lines changed

6 files changed

+895
-1167
lines changed

airbyte_cdk/sources/declarative/concurrent_declarative_source.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def read(
162162
else:
163163
filtered_catalog = catalog
164164

165+
# It is no need run read for synchronous streams if they are not exists.
165166
if not filtered_catalog.streams:
166167
return
167168

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3152,7 +3152,7 @@ definitions:
31523152
type: object
31533153
additionalProperties: true
31543154
StateDelegatingRetriever:
3155-
description: Test state condition retriever.
3155+
description: (This component is experimental. Use at your own risk.) Orchestrate the retriever's usage based on the state value.
31563156
type: object
31573157
required:
31583158
- type
@@ -3168,14 +3168,14 @@ definitions:
31683168
default: false
31693169
full_refresh_retriever:
31703170
title: Retriever
3171-
description: Component used to coordinate how records are extracted across stream slices and request pages.
3171+
description: Component used to coordinate how records are extracted across stream slices and request pages when the state is empty or not provided.
31723172
anyOf:
31733173
- "$ref": "#/definitions/AsyncRetriever"
31743174
- "$ref": "#/definitions/CustomRetriever"
31753175
- "$ref": "#/definitions/SimpleRetriever"
31763176
incremental_retriever:
31773177
title: Retriever
3178-
description: Component used to coordinate how records are extracted across stream slices and request pages.
3178+
description: Component used to coordinate how records are extracted across stream slices and request pages when the state provided.
31793179
anyOf:
31803180
- "$ref": "#/definitions/AsyncRetriever"
31813181
- "$ref": "#/definitions/CustomRetriever"

airbyte_cdk/sources/declarative/models/declarative_component_schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2251,14 +2251,14 @@ class StateDelegatingRetriever(BaseModel):
22512251
full_refresh_retriever: Union[AsyncRetriever, CustomRetriever, SimpleRetriever] = (
22522252
Field(
22532253
...,
2254-
description="Component used to coordinate how records are extracted across stream slices and request pages.",
2254+
description="Component used to coordinate how records are extracted across stream slices and request pages when the state is empty or not provided.",
22552255
title="Retriever",
22562256
)
22572257
)
22582258
incremental_retriever: Union[AsyncRetriever, CustomRetriever, SimpleRetriever] = (
22592259
Field(
22602260
...,
2261-
description="Component used to coordinate how records are extracted across stream slices and request pages.",
2261+
description="Component used to coordinate how records are extracted across stream slices and request pages when the state provided.",
22622262
title="Retriever",
22632263
)
22642264
)

airbyte_cdk/sources/streams/concurrent/partition_enqueuer.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ def generate_partitions(self, stream: AbstractStream) -> None:
5555
#
5656
# Also note that prune_to_validate_has_reached_futures_limit has a lock while pruning which might create a bottleneck in
5757
# terms of performance.
58-
5958
while self._thread_pool_manager.prune_to_validate_has_reached_futures_limit():
6059
time.sleep(self._sleep_time_in_seconds)
6160
self._queue.put(partition)

0 commit comments

Comments
 (0)