Skip to content

Commit b73c89b

Browse files
committed
fix querty properties component creation
1 parent e44362a commit b73c89b

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3193,7 +3193,10 @@ def _get_url() -> str:
31933193

31943194
query_properties_definitions = []
31953195
for key, request_parameter in model.requester.request_parameters.items(): # type: ignore # request_parameters is already validated to be a Mapping using _query_properties_in_request_parameters()
3196-
if isinstance(request_parameter, QueryPropertiesModel):
3196+
if (
3197+
isinstance(request_parameter, dict)
3198+
and request_parameter.get("type") == "QueryProperties"
3199+
):
31973200
query_properties_key = key
31983201
query_properties_definitions.append(request_parameter)
31993202

@@ -3203,8 +3206,10 @@ def _get_url() -> str:
32033206
)
32043207

32053208
if len(query_properties_definitions) == 1:
3206-
query_properties = self._create_component_from_model(
3207-
model=query_properties_definitions[0], config=config
3209+
query_properties = self.create_component(
3210+
model_type=QueryPropertiesModel,
3211+
component_definition=query_properties_definitions[0],
3212+
config=config,
32083213
)
32093214
elif (
32103215
hasattr(model.requester, "fetch_properties_from_endpoint")
@@ -3363,7 +3368,10 @@ def _query_properties_in_request_parameters(
33633368
request_parameters = requester.request_parameters
33643369
if request_parameters and isinstance(request_parameters, Mapping):
33653370
for request_parameter in request_parameters.values():
3366-
if isinstance(request_parameter, QueryPropertiesModel):
3371+
if (
3372+
isinstance(request_parameter, dict)
3373+
and request_parameter.get("type") == "QueryProperties"
3374+
):
33673375
return True
33683376
return False
33693377

0 commit comments

Comments
 (0)