Skip to content

Commit c084c2c

Browse files
committed
file-based: remove unnecesary raise for non-impemented execption for abstract methods
1 parent 87e407e commit c084c2c

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

airbyte_cdk/sources/file_based/file_based_stream_permissions_reader.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,7 @@ def get_file_acl_permissions(self, file: RemoteFile, logger: logging.Logger):
5151
is_public = result["is_public"],
5252
).dict()
5353
"""
54-
raise NotImplementedError(
55-
f"{self.__class__.__name__} does not implement get_file_acl_permissions(). To support ACL permissions, implement this method and update file_permissions_schema."
56-
)
54+
...
5755

5856
@abstractmethod
5957
def load_identity_groups(self, logger: logging.Logger) -> Iterable[Dict[str, Any]]:
@@ -75,9 +73,7 @@ def load_identity_groups(self, logger: logging.Logger) -> Iterable[Dict[str, Any
7573
group_obj.member_email_addresses.append(member.email)
7674
yield group_obj.dict()
7775
"""
78-
raise NotImplementedError(
79-
f"{self.__class__.__name__} does not implement load_identity_groups(). To support identities, implement this method and update identities_schema."
80-
)
76+
...
8177

8278
@property
8379
@abstractmethod
@@ -101,9 +97,7 @@ def file_permissions_schema(self) -> Dict[str, Any]:
10197
}
10298
}
10399
"""
104-
raise NotImplementedError(
105-
f"{self.__class__.__name__} does not implement file_permissions_schema, please return json schema for your permissions streams."
106-
)
100+
...
107101

108102
@property
109103
@abstractmethod
@@ -126,6 +120,4 @@ def identities_schema(self) -> Dict[str, Any]:
126120
}
127121
}
128122
"""
129-
raise NotImplementedError(
130-
f"{self.__class__.__name__} does not implement identities_schema, please return json schema for your identities stream."
131-
)
123+
...

0 commit comments

Comments
 (0)