fixed linters issues

Author: Oleksandr Bazarnov

airbyte_cdk/manifest_migrations/manifest_migration.py

@@ -31,7 +31,7 @@ class MigrationTrace:
     migration: str
     migrated_at: str
 
-    def as_dict(self) -> dict:
+    def as_dict(self) -> Dict[str, Any]:
         return asdict(self)
 
 

airbyte_cdk/manifest_migrations/migration_handler.py

@@ -82,15 +82,23 @@ def _handle_migration(
                 if migration_instance.is_migrated:
                     # set the updated manifest version, after migration has been applied
                     self._set_manifest_version(migration_version)
-                    # set the migration trace
                     self._set_migration_trace(migration_class, manifest_version, migration_version)
             else:
                 LOGGER.info(
-                    f"Manifest migration: `{migration_instance.__name__}` is not supported for the given manifest version `{manifest_version}`.",
+                    f"Manifest migration: `{self._get_migration_name(migration_class)}` is not supported for the given manifest version `{manifest_version}`.",
                 )
         except Exception as e:
             raise ManifestMigrationException(str(e)) from e
 
+    def _get_migration_name(self, migration_class: Type[ManifestMigration]) -> str:
+        """
+        Get the name of the migration instance.
+
+        Returns:
+            str: The name of the migration.
+        """
+        return migration_class.__name__
+
     def _get_manifest_version(self) -> str:
         """
         Get the manifest version from the manifest.
@@ -101,8 +109,20 @@ def _get_manifest_version(self) -> str:
         return str(self._migrated_manifest.get(MANIFEST_VERSION_TAG, "0.0.0"))
 
     def _version_is_valid_for_migration(
-        self, manifest_version: str, migration_version: str
+        self,
+        manifest_version: str,
+        migration_version: str,
     ) -> bool:
+        """
+        Checks if the given manifest version is less than or equal to the specified migration version.
+
+        Args:
+            manifest_version (str): The version of the manifest to check.
+            migration_version (str): The migration version to compare against.
+
+        Returns:
+            bool: True if the manifest version is less than or equal to the migration version, False otherwise.
+        """
         return Version(manifest_version) <= Version(migration_version)
 
     def _set_manifest_version(self, version: str) -> None:
@@ -120,7 +140,7 @@ def _set_migration_trace(
         migration_version: str,
     ) -> None:
         """
-        Set the migration trace in the manifest.
+        Set the migration trace in the manifest, under the `metadata.applied_migrations` property object.
 
         :param migration_instance: The migration instance to set
         :param manifest_version: The manifest version before migration
@@ -135,7 +155,7 @@ def _set_migration_trace(
         migration_trace = MigrationTrace(
             from_version=manifest_version,
             to_version=migration_version,
-            migration=migration_instance.__name__,
+            migration=self._get_migration_name(migration_instance),
             migrated_at=datetime.now(tz=timezone.utc).isoformat(),
         ).as_dict()
 

airbyte_cdk/manifest_migrations/migrations_registry.py

@@ -7,6 +7,7 @@
 import inspect
 import os
 from pathlib import Path
+from types import ModuleType
 from typing import Dict, List, Type
 
 import yaml
@@ -21,22 +22,22 @@
 REGISTRY_PATH = MIGRATIONS_PATH / "registry.yaml"
 
 
-def _find_migration_module(name: str) -> str | None:
+def _find_migration_module(name: str) -> str:
     """
     Finds the migration module by name in the migrations directory.
     The name should match the file name of the migration module (without the .py extension).
     Raises ImportError if the module is not found.
     """
-    try:
-        for migration_file in os.listdir(MIGRATIONS_PATH):
-            migration_name = name + ".py"
-            if migration_file == migration_name:
-                return migration_file.replace(".py", "")
-    except ImportError as e:
-        raise ImportError(f"Migration module '{name}' not found in {MIGRATIONS_PATH}.") from e
 
+    for migration_file in os.listdir(MIGRATIONS_PATH):
+        migration_name = name + ".py"
+        if migration_file == migration_name:
+            return migration_file.replace(".py", "")
 
-def _get_migration_class(module) -> type:
+    raise ImportError(f"Migration module '{name}' not found in {MIGRATIONS_PATH}.")
+
+
+def _get_migration_class(module: ModuleType) -> Type[ManifestMigration]:
     """
     Returns the ManifestMigration subclass defined in the module.
     """
@@ -53,7 +54,7 @@ def _discover_migrations() -> DiscoveredMigrations:
     """
     with open(REGISTRY_PATH, "r") as f:
         registry = yaml.safe_load(f)
-        migrations = {}
+        migrations: DiscoveredMigrations = {}
         # Iterate through the registry and import the migration classes
         # based on the version and order specified in the registry.yaml
         for version_entry in registry.get("manifest_migrations", []):