Skip to content

Commit c4e6ddb

Browse files
committed
test: remove expected-to-fail tests from fast standard tests (resolves false-positive failures)
1 parent acc1003 commit c4e6ddb

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

airbyte_cdk/test/standard_tests/connector_base.py

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,13 +163,24 @@ def get_scenarios(
163163
):
164164
continue
165165

166-
test_scenarios.extend(
167-
[
168-
ConnectorTestScenario.model_validate(test)
169-
for test in all_tests_config["acceptance_tests"][category]["tests"]
170-
if "config_path" in test and "iam_role" not in test["config_path"]
171-
]
172-
)
166+
for test in all_tests_config["acceptance_tests"][category]["tests"]:
167+
scenario = ConnectorTestScenario.model_validate(test)
168+
169+
if "config_path" in test and "iam_role" in test["config_path"]:
170+
# We skip iam_role tests for now, as they are not supported in the test suite.
171+
continue
172+
173+
if scenario.expect_exception:
174+
# For now, we skip tests that are expected to fail.
175+
# This is because they create false-positives in the test suite
176+
# if they fail later than expected.
177+
continue
178+
179+
if scenario.config_path in [s.config_path for s in test_scenarios]:
180+
# Skip duplicate scenarios based on config_path
181+
continue
182+
183+
test_scenarios.append(scenario)
173184

174185
connector_root = cls.get_connector_root_dir().absolute()
175186
for test in test_scenarios:

0 commit comments

Comments
 (0)