Skip to content

Commit c61583a

Browse files
committed
update per comments
1 parent 55625dd commit c61583a

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

airbyte_cdk/sources/declarative/async_job/job_tracker.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ class ConcurrentJobLimitReached(Exception):
1717
class JobTracker:
1818
def __init__(self, limit: int):
1919
self._jobs: Set[str] = set()
20+
if limit < 1:
21+
LOGGER.warning(
22+
f"The `max_concurrent_async_job_count` property is less than 1: {limit}. Setting to 1. Please update the source manifest to set a valid value."
23+
)
2024
self._limit = 1 if limit < 1 else limit
2125
self._lock = threading.Lock()
2226

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ properties:
4343
api_budget:
4444
"$ref": "#/definitions/HTTPAPIBudget"
4545
max_concurrent_async_job_count:
46-
title: Maximum Concurrent Async Jobs
47-
description: Maximum number of concurrent async jobs to run. This property is only relevant for sources/streams that support asynchronous job execution (e.g. a Report stream that requires that initiates a job, polls the job status, and then fetches the job results). This is often set by the API's maximum number of concurrent jobs on the account level.
46+
title: Maximum Concurrent Asynchronous Jobs
47+
description: Maximum number of concurrent asynchronous jobs to run. This property is only relevant for sources/streams that support asynchronous job execution through the AsyncRetriever (e.g. a report-based stream that initiates a job, polls the job status, and then fetches the job results). This is often set by the API's maximum number of concurrent jobs on the account level. Refer to the API's documentation for this information.
4848
type: integer
4949
metadata:
5050
type: object

airbyte_cdk/sources/declarative/models/declarative_component_schema.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1873,8 +1873,8 @@ class Config:
18731873
api_budget: Optional[HTTPAPIBudget] = None
18741874
max_concurrent_async_job_count: Optional[int] = Field(
18751875
None,
1876-
description="Maximum number of concurrent async jobs to run. This property is only relevant for sources/streams that support asynchronous job execution (e.g. a Report stream that requires that initiates a job, polls the job status, and then fetches the job results). This is often set by the API's maximum number of concurrent jobs on the account level.",
1877-
title="Maximum Concurrent Async Jobs",
1876+
description="Maximum number of concurrent asynchronous jobs to run. This property is only relevant for sources/streams that support asynchronous job execution through the AsyncRetriever (e.g. a report-based stream that initiates a job, polls the job status, and then fetches the job results). This is often set by the API's maximum number of concurrent jobs on the account level. Refer to the API's documentation for this information.",
1877+
title="Maximum Concurrent Asynchronous Jobs",
18781878
)
18791879
metadata: Optional[Dict[str, Any]] = Field(
18801880
None,
@@ -1905,8 +1905,8 @@ class Config:
19051905
api_budget: Optional[HTTPAPIBudget] = None
19061906
max_concurrent_async_job_count: Optional[int] = Field(
19071907
None,
1908-
description="Maximum number of concurrent async jobs to run. This property is only relevant for sources/streams that support asynchronous job execution (e.g. a Report stream that requires that initiates a job, polls the job status, and then fetches the job results). This is often set by the API's maximum number of concurrent jobs on the account level.",
1909-
title="Maximum Concurrent Async Jobs",
1908+
description="Maximum number of concurrent asynchronous jobs to run. This property is only relevant for sources/streams that support asynchronous job execution through the AsyncRetriever (e.g. a report-based stream that initiates a job, polls the job status, and then fetches the job results). This is often set by the API's maximum number of concurrent jobs on the account level. Refer to the API's documentation for this information.",
1909+
title="Maximum Concurrent Asynchronous Jobs",
19101910
)
19111911
metadata: Optional[Dict[str, Any]] = Field(
19121912
None,

0 commit comments

Comments
 (0)