Skip to content

Commit cfe9895

Browse files
committed
CDK: ref add comment
Signed-off-by: Artem Inzhyyants <[email protected]>
1 parent c673c2c commit cfe9895

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

airbyte_cdk/sources/declarative/concurrent_declarative_source.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -402,19 +402,19 @@ def _is_datetime_incremental_without_partition_routing(
402402
and bool(incremental_sync_component_definition)
403403
and (
404404
incremental_sync_component_definition.get("type", "")
405-
== DatetimeBasedCursorModel.__name__
406-
or incremental_sync_component_definition.get("type", "")
407-
== IncrementingCountCursorModel.__name__
405+
in (DatetimeBasedCursorModel.__name__, IncrementingCountCursorModel.__name__)
408406
)
409407
and self._stream_supports_concurrent_partition_processing(
410408
declarative_stream=declarative_stream
411409
)
412410
and hasattr(declarative_stream.retriever, "stream_slicer")
413411
and (
414412
isinstance(declarative_stream.retriever.stream_slicer, DatetimeBasedCursor)
415-
or isinstance(
416-
declarative_stream.retriever.stream_slicer, IncrementingCountCursorModel
417-
)
413+
# IncrementingCountCursorModel is hardcoded to be of type DatetimeBasedCursor
414+
# add isntance check here if we want to have a IncrementingCountCursor
415+
# or isinstance(
416+
# declarative_stream.retriever.stream_slicer, IncrementingCountCursor
417+
# )
418418
or isinstance(declarative_stream.retriever.stream_slicer, AsyncJobPartitionRouter)
419419
)
420420
)

0 commit comments

Comments
 (0)