Commit d99a964
committed
fix(low-code): handle all ScannerError exceptions in ConfigComponentsResolver
Previously, the _parse_yaml_if_possible method only caught ScannerError
exceptions containing '%' characters, but re-raised other ScannerError
types. This caused failures when strings containing tab characters were
passed through the YAML parser, as tabs cannot start tokens in YAML.
This fix catches all ScannerError exceptions and returns the original
value unchanged, which is the expected behavior for strings that are
not valid YAML.
Fixes: airbytehq/oncall#10280
Co-Authored-By: unknown <>1 parent 80b7668 commit d99a964
File tree
2 files changed
+18
-5
lines changed- airbyte_cdk/sources/declarative/resolvers
- unit_tests/sources/declarative/resolvers
2 files changed
+18
-5
lines changedLines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
| 207 | + | |
| 208 | + | |
211 | 209 | | |
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
163 | 177 | | |
164 | 178 | | |
165 | 179 | | |
| |||
173 | 187 | | |
174 | 188 | | |
175 | 189 | | |
| 190 | + | |
176 | 191 | | |
177 | | - | |
| 192 | + | |
178 | 193 | | |
179 | 194 | | |
180 | 195 | | |
| |||
0 commit comments