ai overlord review suggestions

Author: pedroslopez

airbyte_cdk/manifest_server/README.md

@@ -16,7 +16,7 @@ poetry install --extras manifest-server
 pip install airbyte-cdk[manifest-server]
 
 # Using uv
-uv pip install 'airbyte-cdk[manifest-runner]'
+uv pip install 'airbyte-cdk[manifest-server]'
 ```
 
 ### Running the Server
@@ -36,27 +36,27 @@ The server will start on `http://localhost:8000` by default.
 
 ## API Endpoints
 
-### `/manifest/test_read`
+### `/v1/manifest/test_read`
 Test reading from a specific stream in the manifest.
 
 **POST** - Test stream reading with configurable limits for records, pages, and slices.
 
-### `/manifest/check`
+### `/v1/manifest/check`
 Check configuration against a manifest.
 
 **POST** - Validates connector configuration and returns success/failure status with message.
 
-### `/manifest/discover`
+### `/v1/manifest/discover`
 Discover streams from a manifest.
 
 **POST** - Returns the catalog of available streams from the manifest.
 
-### `/manifest/resolve` 
+### `/v1/manifest/resolve` 
 Resolve a manifest to its final configuration.
 
 **POST** - Returns the resolved manifest without dynamic stream generation.
 
-### `/manifest/full_resolve`
+### `/v1/manifest/full_resolve`
 Fully resolve a manifest including dynamic streams.
 
 **POST** - Generates dynamic streams up to specified limits and includes them in the resolved manifest.
@@ -86,7 +86,7 @@ export AB_JWT_SIGNATURE_SECRET="your-jwt-secret-key"
 When authentication is enabled, include a valid JWT token in the Authorization header:
 ```bash
 curl -H "Authorization: Bearer <your-jwt-token>" \
-  http://localhost:8000/manifest/test_read
+  http://localhost:8000/v1/manifest/test_read
 ```
 
 ### Behavior

airbyte_cdk/manifest_server/api_models/manifest.py

@@ -19,7 +19,7 @@ class StreamTestReadRequest(BaseModel):
     manifest: Manifest
     config: ConnectorConfig
     stream_name: str
-    state: List[Any] = []
+    state: List[Any] = Field(default_factory=list)
     custom_components_code: Optional[str] = None
     record_limit: int = Field(default=100, ge=1, le=5000)
     page_limit: int = Field(default=5, ge=1, le=20)

airbyte_cdk/manifest_server/app.py

@@ -1,6 +1,6 @@
 from fastapi import FastAPI
 
-from ..manifest_server.routers import capabilities, health, manifest
+from .routers import capabilities, health, manifest
 
 app = FastAPI(
     title="Manifest Server",

airbyte_cdk/manifest_server/routers/manifest.py

@@ -73,28 +73,29 @@ def test_read(request: StreamTestReadRequest) -> StreamRead:
     config_dict = request.config.model_dump()
 
     catalog = build_catalog(request.stream_name)
+    converted_state = [AirbyteStateMessageSerializer.load(state) for state in request.state]
+
+    if request.custom_components_code:
+        config_dict[INJECTED_COMPONENTS_PY] = request.custom_components_code
+        config_dict[INJECTED_COMPONENTS_PY_CHECKSUMS] = {
+            "md5": hashlib.md5(request.custom_components_code.encode()).hexdigest()
+        }
+
     source = safe_build_source(
         request.manifest.model_dump(),
         config_dict,
         catalog,
-        request.state,
+        converted_state,
         request.page_limit,
         request.slice_limit,
         request.record_limit,
     )
-    state = [AirbyteStateMessageSerializer.load(state) for state in request.state]
-
-    if request.custom_components_code:
-        config_dict[INJECTED_COMPONENTS_PY] = request.custom_components_code
-        config_dict[INJECTED_COMPONENTS_PY_CHECKSUMS] = {
-            "md5": hashlib.md5(request.custom_components_code.encode()).hexdigest()
-        }
 
     runner = ManifestCommandProcessor(source)
     cdk_result = runner.test_read(
         config_dict,
         catalog,
-        state,
+        converted_state,
         request.record_limit,
         request.page_limit,
         request.slice_limit,

pyproject.toml

@@ -210,7 +210,7 @@ ignore = [
 [tool.airbyte_ci]
 python_versions = ["3.10", "3.11"]
 optional_poetry_groups = ["dev"]
-poetry_extras = ["file-based", "vector-db-based"]
+poetry_extras = ["file-based", "vector-db-based", "manifest-server"]
 poe_tasks = ["check-ci"]
 mount_docker_socket = true