refactor: move check_config_during_discover to BaseConnector class

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Author: devin-ai-integration[bot]

airbyte_cdk/connector.py

@@ -33,6 +33,14 @@ def load_optional_package_file(package: str, filename: str) -> Optional[bytes]:
 class BaseConnector(ABC, Generic[TConfig]):
     # configure whether the `check_config_against_spec_or_exit()` needs to be called
     check_config_against_spec: bool = True
+    
+    check_config_during_discover: bool = False
+    """
+    Determines whether config validation should be skipped during discovery.
+    
+    By default, config validation is not skipped during discovery. This can be overridden
+    by sources that can provide catalog information without requiring authentication.
+    """
 
     @abstractmethod
     def configure(self, config: Mapping[str, Any], temp_dir: str) -> TConfig:

airbyte_cdk/sources/abstract_source.py

@@ -324,28 +324,3 @@ def stop_sync_on_stream_failure(self) -> bool:
         on the first error seen and emit a single error trace message for that stream.
         """
         return False
-
-    _check_config_during_discover: bool = False
-    
-    @property
-    def check_config_during_discover(self) -> bool:
-        """
-        Determines whether config validation should be skipped during discovery.
-
-        By default, config validation is not skipped during discovery. This can be overridden
-        by sources that can provide catalog information without requiring authentication.
-
-        Returns:
-            bool: True if config validation should be skipped during discovery, False otherwise.
-        """
-        return self._check_config_during_discover
-        
-    @check_config_during_discover.setter
-    def check_config_during_discover(self, value: bool) -> None:
-        """
-        Sets whether config validation should be skipped during discovery.
-        
-        Args:
-            value: True if config validation should be skipped during discovery, False otherwise.
-        """
-        self._check_config_during_discover = value

unit_tests/sources/declarative/test_manifest_declarative_source_dynamic_schema.py

@@ -1,6 +1,9 @@
 #
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 #
 
+"""Tests for the ManifestDeclarativeSource with DynamicSchemaLoader."""
+
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -65,7 +68,7 @@ def test_check_config_during_discover_without_dynamic_schema_loader():
     }
 
     source = ManifestDeclarativeSource(source_config=source_config)
-
+    
     assert source.check_config_during_discover is False
     assert source.check_config_against_spec is True