-
Notifications
You must be signed in to change notification settings - Fork 33
fix(cdk): replace direct datetime parsing/formatting with datetime_helpers (do not merge) #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devin-ai-integration
wants to merge
19
commits into
main
from
devin/1744154835-datetime-helpers-refactor
Closed
fix(cdk): replace direct datetime parsing/formatting with datetime_helpers (do not merge) #465
devin-ai-integration
wants to merge
19
commits into
main
from
devin/1744154835-datetime-helpers-refactor
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lpers Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Contributor
Author
|
Original prompt from Aaron: |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…me objects Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…first Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Contributor
Author
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces direct datetime parsing and formatting with standardized implementations from the datetime_helpers module as documented in the Airbyte Python CDK documentation. It also fixes a bug in ab_datetime_format() where it doesn't respect the requested format when an AirbyteDateTime object is passed.
Link to Devin run: https://app.devin.ai/sessions/dc992333d5b04a3cb9aed7db246b30de
Requested by: Aaron ("AJ") Steers ([email protected])