Skip to content

feat(cdk): connector builder support for file uploader #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aldogonzalez8 wants to merge 19 commits into from
Closed

feat(cdk): connector builder support for file uploader #492

aldogonzalez8 wants to merge 19 commits into from

Conversation

@aldogonzalez8
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 commented Apr 17, 2025 •
edited
Loading

What

We want to implement support for the connector builder to communicate about the files that will be uploaded for the streams.

How

Current Implementation:

  • Runtime (emit_connector_builder_messages=False):
    • FileUploader is instantiated with a standard FileWriter, which performs the actual file writing.
  • Connector Builder (emit_connector_builder_messages=True):
    • FileUploader is instantiated with a NoopFileWriter, preventing actual file writes.
    • This FileUploader instance is then wrapped by ConnectorBuilderFileUploader.
    • ConnectorBuilderFileUploader.upload() first calls the wrapped FileUploader.upload() (which populates record.file_reference but doesn't write the file) and then performs the Connector Builder-specific action of copying file_reference attributes into record.data.

maxi297 and others added 12 commits March 19, 2025 12:16
PoC for file upload
d1d5107
Auto-fix lint and format issues
de09ae8
fix mypy
b410187
@aldogonzalez8 @maxi297
PoC for emit file reference record (#443)
b122c0a 
Co-authored-by: Maxime Carbonneau-Leclerc <[email protected]>
Co-authored-by: octavia-squidington-iii <[email protected]>
@aldogonzalez8
merge from main
4c29c91
@aldogonzalez8 @maxi297
@aaronsteers @devin-ai-integration
feat(PoC): adjust file-based and file uploader component to latest pr…
b5b8197 
…otocol changes. (#457)

Co-authored-by: Maxime Carbonneau-Leclerc <[email protected]>
Co-authored-by: octavia-squidington-iii <[email protected]>
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@aldogonzalez8
merge from main
d060a8b
@aldogonzalez8
poetry lock
87c20b6
@aldogonzalez8
file-api: add checks for missin values/paths
ab5d4e7
@aldogonzalez8
file-api: fix unit tests
5242876
Auto-fix lint and format issues
8f14512
@aldogonzalez8
connector builder: initial changes to pass file reference info to data
3c0c0ab
@aldogonzalez8 aldogonzalez8 self-assigned this Apr 17, 2025
@github-actions github-actions bot added the enhancement New feature or request label Apr 17, 2025
@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Apr 17, 2025 •
edited by github-actions bot
Loading

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Apr 17, 2025 •
edited by github-actions bot
Loading

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Apr 17, 2025 •
edited by github-actions bot
Loading

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Apr 18, 2025 •
edited by github-actions bot
Loading

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

@aldogonzalez8 aldogonzalez8 changed the title feat(connector builder): initial changes to pass file reference info to data feat(cdk): connector builder support for file uploader Apr 18, 2025
@aldogonzalez8 aldogonzalez8 marked this pull request as ready for review April 18, 2025 15:44
@aldogonzalez8 aldogonzalez8 requested a review from maxi297 April 18, 2025 16:07
Base automatically changed from maxi297/poc-file-upload to main April 22, 2025 14:41
@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Apr 23, 2025

Closed in favor of #503

@aldogonzalez8
Copy link
Contributor Author

aldogonzalez8 commented Apr 23, 2025

Closed in favor of #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxi297 maxi297 Awaiting requested review from maxi297

Assignees

@aldogonzalez8 aldogonzalez8

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aldogonzalez8