-
Notifications
You must be signed in to change notification settings - Fork 34
feat: add secrets fetch command to CDK CLI #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aaronsteers
merged 21 commits into
aj/feat/add-standard-tests-cli
from
devin/1744945591-add-secrets-fetch-command
Apr 18, 2025
Merged
feat: add secrets fetch command to CDK CLI #494
aaronsteers
merged 21 commits into
aj/feat/add-standard-tests-cli
from
devin/1744945591-add-secrets-fetch-command
Apr 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Contributor
Author
|
Original prompt from Aaron: |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…ntributing guide Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 18, 2025
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
reviewed
Apr 18, 2025
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
…dd-secrets-fetch-command
…=__doc__ Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
aaronsteers
approved these changes
Apr 18, 2025
6fdf2c6
into
aj/feat/add-standard-tests-cli
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets the following PR:
airbyte-cdkCLI with support for:connector test,secrets fetchand--version#493Added a 'secrets fetch' command to the airbyte-cdk CLI that can fetch connector secrets from Google Secret Manager. This provides functionality similar to the PyAirbyte script 'run_gsm_connector_secret_fetch.py'.
The command follows the same patterns as existing commands like 'connector test', allowing users to specify either a connector name or directory.
The Google Secret Manager dependency is added as an optional dependency in the 'dev' extras to avoid adding it as a requirement for production use.
Link to Devin run: https://app.devin.ai/sessions/121e177095fa41d4ae43dcfae597f3de
Requested by: Aaron ("AJ") Steers