fix: interpolation should not generate complex types by maxi297 · Pull Request #579 · airbytehq/airbyte-python-cdk

Maxime Carbonneau-Leclerc (maxi297) · 2025-06-04T19:09:42Z

Summary by CodeRabbit

Bug Fixes
- Improved handling of complex number values during interpolation to ensure they are returned as strings when appropriate.
Tests
- Updated tests to verify that complex number strings are correctly returned as strings, reflecting the improved handling.

coderabbitai · 2025-06-04T19:15:08Z

📝 Walkthrough

Walkthrough

This update modifies the handling of complex number evaluation in the Jinja interpolation logic, ensuring complex types are not returned unless explicitly allowed. The command-line entrypoint for debugging manifests is refactored for clearer argument parsing and source construction. Associated unit tests are updated to reflect the new complex number handling.

Changes

File(s)	Change Summary
airbyte_cdk/sources/declarative/interpolation/jinja.py	Updated `_literal_eval` to exclude `complex` type values unless explicitly allowed via `valid_types`.
debug_manifest/debug_manifest.py	Refactored main block: improved argument parsing, dynamic source construction, and updated how arguments are passed.
unit_tests/sources/declarative/interpolation/test_jinja.py	Removed parameterized complex number test; added simpler tests verifying complex strings return as strings or complex.

Sequence Diagram(s)

sequenceDiagram
    participant CLI_User
    participant debug_manifest.py
    participant AirbyteEntrypoint
    participant YamlDeclarativeSource

    CLI_User->>debug_manifest.py: Run script with CLI args
    debug_manifest.py->>AirbyteEntrypoint: Parse catalog/config/state paths
    debug_manifest.py->>YamlDeclarativeSource: Instantiate with manifest and optional data
    debug_manifest.py->>debug_manifest.py: Call debug_manifest with constructed args

Would you like to add further tests for other edge cases in the interpolation logic, such as handling other non-standard types? Wdyt?

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa6587c and ae62cd3.

📒 Files selected for processing (2)

airbyte_cdk/sources/declarative/interpolation/jinja.py (1 hunks)
unit_tests/sources/declarative/interpolation/test_jinja.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

unit_tests/sources/declarative/interpolation/test_jinja.py
airbyte_cdk/sources/declarative/interpolation/jinja.py

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Check: 'source-amplitude' (skip=false)
GitHub Check: Check: 'source-shopify' (skip=false)
GitHub Check: Check: 'source-hardcoded-records' (skip=false)
GitHub Check: Pytest (Fast)
GitHub Check: Pytest (All, Python 3.11, Ubuntu)
GitHub Check: Pytest (All, Python 3.10, Ubuntu)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Maxime Carbonneau-Leclerc (maxi297) · 2025-06-05T12:04:41Z

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

github-actions · 2025-06-05T12:12:01Z

PyTest Results (Fast)

3 655 tests 3 645 ✅ 5m 40s ⏱️
1 suites 10 💤
1 files 0 ❌

Results for commit ae62cd3.

github-actions · 2025-06-05T12:23:54Z

PyTest Results (Full)

3 658 tests 3 648 ✅ 17m 24s ⏱️
1 suites 10 💤
1 files 0 ❌

Results for commit ae62cd3.

Alfredo Garcia (agarctfi)

LGTM

Maxime Carbonneau-Leclerc (maxi297) · 2025-06-05T14:14:16Z

Note that in order to still continue supporting complex, we would need to add it here but until we support the serialization of these, I don't see why we would

Brian Lai (brianjlai)

interpolation should not generate complex types

aa6587c

coderabbitai bot approved these changes Jun 4, 2025

View reviewed changes

adding test for complex

8de1c6d

Maxime Carbonneau-Leclerc (maxi297) changed the title ~~interpolation should not generate complex types~~ fix: interpolation should not generate complex types Jun 5, 2025

Auto-fix lint and format issues

ae62cd3

github-actions bot added bug Something isn't working security labels Jun 5, 2025

Maxime Carbonneau-Leclerc (maxi297) requested review from Alfredo Garcia (agarctfi) and Brian Lai (brianjlai) June 5, 2025 12:06

Alfredo Garcia (agarctfi) approved these changes Jun 5, 2025

View reviewed changes

Alfredo Garcia (agarctfi) mentioned this pull request Jun 5, 2025

(Fix: Source-Paypal-Transactions): Update CDK - TypeErrors with ids interpreted as complex datatypes airbytehq/airbyte#58674

Merged

2 tasks

Brian Lai (brianjlai) approved these changes Jun 5, 2025

View reviewed changes

Maxime Carbonneau-Leclerc (maxi297) merged commit 3469ace into main Jun 5, 2025
30 checks passed

Maxime Carbonneau-Leclerc (maxi297) deleted the oncall-58674/interpolation-should-not-give-complex-types branch June 5, 2025 17:25

Maxime Carbonneau-Leclerc (maxi297) mentioned this pull request Sep 24, 2025

[custom-connector] Builder parses "XXXXXXXXXXXXXXXXJ" ids as complex numbers and fails validating schema airbytehq/airbyte#58630

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: interpolation should not generate complex types#579

fix: interpolation should not generate complex types#579
Maxime Carbonneau-Leclerc (maxi297) merged 3 commits intomainfrom
oncall-58674/interpolation-should-not-give-complex-types

Maxime Carbonneau-Leclerc (maxi297) commented Jun 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 4, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) commented Jun 5, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

Alfredo Garcia (agarctfi) left a comment

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) commented Jun 5, 2025 •

edited

Loading

Uh oh!

Brian Lai (brianjlai) left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Maxime Carbonneau-Leclerc (maxi297) commented Jun 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) commented Jun 5, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025

PyTest Results (Fast)

Uh oh!

github-actions bot commented Jun 5, 2025

PyTest Results (Full)

Uh oh!

Alfredo Garcia (agarctfi) left a comment

Choose a reason for hiding this comment

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Brian Lai (brianjlai) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Maxime Carbonneau-Leclerc (maxi297) commented Jun 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Maxime Carbonneau-Leclerc (maxi297) commented Jun 5, 2025 •

edited by github-actions bot

Loading

Maxime Carbonneau-Leclerc (maxi297) commented Jun 5, 2025 •

edited

Loading