Skip to content

Conversation

@pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Aug 28, 2025

Introducing manifest-server adds new references to the CDK version in the platform repo.

This PR adds those references to the list of version replacements that already happens automatically when publishing to make sure the version is kept up to date and CI is triggered to run tests.

Summary by CodeRabbit

  • Chores
    • Release workflow now automatically propagates new version strings to related artifacts, updating tags and references across ancillary manifests during connector builder updates.
    • Reduces manual updates and risk of mismatched versions, improving consistency and reliability of published packages.
    • No user-facing behavior changes; internal publishing is more predictable.

@github-actions github-actions bot added the enhancement New feature or request label Aug 28, 2025
@github-actions
Copy link

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@pedro/autoupdate-msnif-serv-cdk-version-platform#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch pedro/autoupdate-msnif-serv-cdk-version-platform

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@pedroslopez pedroslopez marked this pull request as ready for review August 28, 2025 00:10
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

📝 Walkthrough

Walkthrough

Adds two version-string substitution steps to the update-connector-builder workflow to replace CDK tag references in Helm values and a Gradle build file; all other workflow steps remain unchanged.

Changes

Cohort / File(s) Summary
CI workflow: update-connector-builder substitutions
.github/workflows/publish.yml
Adds steps to replace tag: PREVIOUS_VERSIONtag: VERSION in oss/charts/v2/airbyte/values.yaml and to replace refs/tags/vPREVIOUS_VERSIONrefs/tags/vVERSION in oss/airbyte-api/manifest-server-api/build.gradle.kts. Existing steps (Dockerfile/requirements.in updates, CDK_VERSION write, directory changes, pip-tools install) unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant WF as update-connector-builder Job
    participant Repo as Repository

    Dev->>GH: Push new CDK version
    GH->>WF: Trigger workflow
    WF->>Repo: Update Dockerfile / requirements.in (existing)
    WF->>Repo: Write CDK_VERSION file (existing)
    Note over WF,Repo: New substitution steps
    WF->>Repo: Replace tag PREVIOUS_VERSION -> VERSION in oss/charts/v2/airbyte/values.yaml
    WF->>Repo: Replace refs/tags/vPREVIOUS_VERSION -> refs/tags/vVERSION in oss/airbyte-api/manifest-server-api/build.gradle.kts
    WF->>Repo: Install pip-tools (existing)
    WF-->>Dev: Commit/PR with updated files
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • aaronsteers
  • bnchrch
  • alafanechere

Would these reviewers work for this change, wdyt?


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5e725c9 and e99f204.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/publish.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Manifest Server Docker Image Build
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pedro/autoupdate-msnif-serv-cdk-version-platform

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

PyTest Results (Fast)

3 762 tests  ±0   3 751 ✅ ±0   7m 2s ⏱️ -5s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e99f204. ± Comparison against base commit 784bdb3.

♻️ This comment has been updated with latest results.

@pedroslopez pedroslopez merged commit ea76ce2 into main Aug 28, 2025
20 checks passed
@pedroslopez pedroslopez deleted the pedro/autoupdate-msnif-serv-cdk-version-platform branch August 28, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants