-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add manifest-server references to auto platform CDK version bump #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manifest-server references to auto platform CDK version bump #731
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@pedro/autoupdate-msnif-serv-cdk-version-platform#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch pedro/autoupdate-msnif-serv-cdk-version-platformHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
aaronsteers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
📝 WalkthroughWalkthroughAdds two version-string substitution steps to the update-connector-builder workflow to replace CDK tag references in Helm values and a Gradle build file; all other workflow steps remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant WF as update-connector-builder Job
participant Repo as Repository
Dev->>GH: Push new CDK version
GH->>WF: Trigger workflow
WF->>Repo: Update Dockerfile / requirements.in (existing)
WF->>Repo: Write CDK_VERSION file (existing)
Note over WF,Repo: New substitution steps
WF->>Repo: Replace tag PREVIOUS_VERSION -> VERSION in oss/charts/v2/airbyte/values.yaml
WF->>Repo: Replace refs/tags/vPREVIOUS_VERSION -> refs/tags/vVERSION in oss/airbyte-api/manifest-server-api/build.gradle.kts
WF->>Repo: Install pip-tools (existing)
WF-->>Dev: Commit/PR with updated files
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Would these reviewers work for this change, wdyt? 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Introducing manifest-server adds new references to the CDK version in the platform repo.
This PR adds those references to the list of version replacements that already happens automatically when publishing to make sure the version is kept up to date and CI is triggered to run tests.
Summary by CodeRabbit