Skip to content

Commit 0bb3665

Browse files
authored
Upgrade develocity plugin; disable failOnSkippedAfterRetry (#69221)
1 parent 55bb5d8 commit 0bb3665

File tree

2 files changed

+20
-15
lines changed

2 files changed

+20
-15
lines changed

buildSrc/src/main/groovy/airbyte-bulk-connector.gradle

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -226,18 +226,23 @@ class AirbyteBulkConnectorPlugin implements Plugin<Project> {
226226
showStandardStreams = true
227227
}
228228

229-
retry {
230-
// If running in CI, enable retries to mitigate flakiness
231-
if (System.getenv().containsKey("CI")) {
232-
// Run each test method up to three times
233-
maxRetries = 3
234-
// If any test method fails, disable retries for the other tests
235-
// (unintuitive: if you set this to 1, then as soon as a test case fails, it will disable retries, including for itself.
236-
// So we set to 2, which means: a test case failing will retry itself. If, after three retries, it still fails, then we disable retries globally.)
237-
maxFailures = 2
229+
develocity {
230+
testRetry {
231+
// If running in CI, enable retries to mitigate flakiness
232+
if (System.getenv().containsKey("CI")) {
233+
// Run each test method up to three times
234+
maxRetries = 3
235+
// If any test method fails, disable retries for the other tests
236+
// (unintuitive: if you set this to 1, then as soon as a test case fails, it will disable retries, including for itself.
237+
// So we set to 2, which means: a test case failing will retry itself. If, after three retries, it still fails, then we disable retries globally.)
238+
maxFailures = 2
239+
}
240+
// If a test fails, but succeeds on retry - don't fail the task
241+
failOnPassedAfterRetry = false
242+
// If a test fails, but is skipped on retry (e.g., due to failed assumptions) - don't fail the task.
243+
// This handles cases where tests use Assumptions.assumeTrue() to conditionally skip themselves.
244+
failOnSkippedAfterRetry = false
238245
}
239-
// If a test fails, but succeeds on retry - don't fail the task
240-
failOnPassedAfterRetry = false
241246
}
242247
reports {
243248
junitXml {

settings.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ pluginManagement {
2020
// Configure the gradle enterprise plugin to enable build scans. Enabling the plugin at the top of the settings file allows the build scan to record
2121
// as much information as possible.
2222
plugins {
23-
id "com.gradle.enterprise" version "3.15.1"
23+
id "com.gradle.develocity" version "3.19.2"
2424
id 'com.github.burrunan.s3-build-cache' version "1.8.1"
2525
}
2626

@@ -114,10 +114,10 @@ dependencyResolutionManagement {
114114
}
115115
}
116116

117-
gradleEnterprise {
117+
develocity {
118118
buildScan {
119-
termsOfServiceUrl = "https://gradle.com/terms-of-service"
120-
termsOfServiceAgree = "yes"
119+
termsOfUseUrl = "https://gradle.com/terms-of-service"
120+
termsOfUseAgree = "yes"
121121
uploadInBackground = !isCI // Disable in CI or scan URLs may not work.
122122
buildScanPublished { PublishedBuildScan scan ->
123123
file("scan-journal.log") << "${new Date()} - ${scan.buildScanId} - ${scan.buildScanUri}\n"

0 commit comments

Comments
 (0)