Skip to content

Commit db8dea8

Browse files
connector-ci: remove acceptance test suite check (#69178)
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
1 parent 2aa2d02 commit db8dea8

File tree

6 files changed

+7
-172
lines changed

6 files changed

+7
-172
lines changed

airbyte-ci/connectors/connectors_qa/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ poe lint
108108

109109
## Changelog
110110

111+
### 1.10.3
112+
113+
Remove check that connectors enable the deprecated "acceptanceTests" test suite.
114+
111115
### 1.10.2
112116
Update Python version requirement from 3.10 to 3.11.
113117

airbyte-ci/connectors/connectors_qa/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "connectors-qa"
3-
version = "1.10.2"
3+
version = "1.10.3"
44
description = "A package to run QA checks on Airbyte connectors, generate reports and documentation."
55
authors = ["Airbyte <[email protected]>"]
66
readme = "README.md"

airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from .metadata import ENABLED_CHECKS as METADATA_CORRECTNESS_CHECKS
55
from .packaging import ENABLED_CHECKS as PACKAGING_CHECKS
66
from .security import ENABLED_CHECKS as SECURITY_CHECKS
7-
from .testing import ENABLED_CHECKS as TESTING_CHECKS
87
from .version import ENABLED_CHECKS as VERSION_CHECKS
98

109
ENABLED_CHECKS = (
@@ -13,6 +12,5 @@
1312
+ PACKAGING_CHECKS
1413
+ ASSETS_CHECKS
1514
+ SECURITY_CHECKS
16-
+ TESTING_CHECKS
1715
+ VERSION_CHECKS
1816
)

airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/testing.py

Lines changed: 0 additions & 41 deletions
This file was deleted.

airbyte-ci/connectors/connectors_qa/tests/unit_tests/test_checks/test_testing.py

Lines changed: 0 additions & 114 deletions
This file was deleted.

docs/contributing-to-airbyte/resources/qa-checks.md

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ _Applies to connector with any support level_
334334
_Applies to connector with any internal support level_
335335
_Applies to connector with any Airbyte usage level_
336336

337-
Connectors must be licensed under the MIT or Elv2 license. This is to ensure that all connectors are licensed under a permissive license. More details in our [License FAQ](https://docs.airbyte.com/community/licenses/license-faq).
337+
Connectors must be licensed under the MIT or Elv2 license. This is to ensure that all connectors are licensed under a permissive license. More details in our [License FAQ](https://docs.airbyte.com/developer-guides/licenses/license-faq).
338338

339339
### Connector license in metadata.yaml and pyproject.toml file must match
340340

@@ -354,7 +354,7 @@ _Applies to connector with any support level_
354354
_Applies to connector with any internal support level_
355355
_Applies to connector with any Airbyte usage level_
356356

357-
Connector version must follow the Semantic Versioning scheme. This is to ensure that all connectors follow a consistent versioning scheme. Refer to our [Semantic Versioning for Connectors](https://docs.airbyte.com/community/contributing-to-airbyte/resources/pull-requests-handbook#semantic-versioning-for-connectors) for more details.
357+
Connector version must follow the Semantic Versioning scheme. This is to ensure that all connectors follow a consistent versioning scheme. Refer to our [Semantic Versioning for Connectors](https://docs.airbyte.com/contributing-to-airbyte/#semantic-versioning-for-connectors) for more details.
358358

359359
### Connector version in metadata.yaml and pyproject.toml file must match
360360

@@ -421,18 +421,6 @@ _Applies to connector with any Airbyte usage level_
421421
Connectors must use our Python connector base image (`docker.io/airbyte/python-connector-base`), declared through the `connectorBuildOptions.baseImage` in their `metadata.yaml`.
422422
This is to ensure that all connectors use a base image which is maintained and has security updates.
423423

424-
## 🧪 Testing
425-
426-
### Medium to High Use Connectors must enable acceptance tests
427-
428-
_Applies to the following connector types: source_
429-
_Applies to the following connector languages: java, low-code, python, manifest-only_
430-
_Applies to connector with any support level_
431-
_Applies to connector with any internal support level_
432-
_Applies to connector with medium, high Airbyte usage level_
433-
434-
Medium to High Use Connectors must enable acceptance tests via the `connectorTestSuitesOptions.suite:acceptanceTests` in their respective metadata.yaml file to ensure that the connector is working as expected.
435-
436424
## 🔢 Version
437425

438426
### Connector Version Increment Check

0 commit comments

Comments
 (0)