CH: Properly scale decimals before validating size. (#69154)

Author: tryangul

airbyte-integrations/connectors/destination-clickhouse/metadata.yaml

@@ -2,7 +2,7 @@ data:
   connectorSubtype: database
   connectorType: destination
   definitionId: ce0d828e-1dc4-496c-b122-2da42e637e48
-  dockerImageTag: 2.1.9
+  dockerImageTag: 2.1.10
   dockerRepository: airbyte/destination-clickhouse
   githubIssueLabel: destination-clickhouse
   icon: clickhouse.svg

airbyte-integrations/connectors/destination-clickhouse/src/main/kotlin/io/airbyte/integrations/destination/clickhouse/write/transform/ClickhouseCoercer.kt

@@ -117,11 +117,14 @@ class ClickhouseCoercer : ValueCoercer {
         val INT64_MIN = BigInteger(Long.MIN_VALUE.toString())
 
         // below are copied from "deprecated" but still actively used
-        // com.clickhouse.data.format.BinaryStreamUtils.DECIMAL64_MAX
+        // com.clickhouse.data.format.BinaryStreamUtils
         // we can't directly use them because the deprecated status causes a
         // compiler warning which we don't tolerate in CI :smithers:
-        val DECIMAL128_MAX = BigDecimal("100000000000000000000000000000000000000")
-        val DECIMAL128_MIN = BigDecimal("-100000000000000000000000000000000000000")
+        //
+        // Further scale the CH defined limits by -9 (our defined scale for decimals) to mimic their
+        // scaling without the overhead (they multiply every value by the scale before comparison).
+        val DECIMAL128_MAX = BigDecimal("100000000000000000000000000000")
+        val DECIMAL128_MIN = BigDecimal("-100000000000000000000000000000")
 
         // used by both date 32 and date time 64
         val DATE32_MAX_RAW = LocalDate.of(2299, 12, 31)

airbyte-integrations/connectors/destination-clickhouse/src/test/kotlin/io/airbyte/integrations/destination/clickhouse/write/transform/ClickhouseCoercerTest.kt

@@ -41,8 +41,8 @@ import java.time.LocalDateTime
 import java.time.LocalTime
 import java.time.OffsetTime
 import java.time.ZoneOffset
-import kotlin.test.Test
 import kotlin.test.assertEquals
+import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 import org.junit.jupiter.params.ParameterizedTest
 import org.junit.jupiter.params.provider.Arguments
@@ -250,6 +250,7 @@ class ClickhouseCoercerTest {
                 Arguments.of("100000000000000000000000000000000000001"),
                 Arguments.of("999999999999999999999999999999999999999.9"),
                 Arguments.of("-999999999999999999999999999999999999999.12"),
+                Arguments.of("3.4028234663852886E+37"),
             )
 
         @JvmStatic

docs/integrations/destinations/clickhouse.md

@@ -104,6 +104,7 @@ You can also use a pre-existing user but we highly recommend creating a dedicate
 
 | Version    | Date       | Pull Request                                               | Subject                                                                        |
 |:-----------|:-----------|:-----------------------------------------------------------|:-------------------------------------------------------------------------------|
+| 2.1.10     | 2025-11-03 | [69154](https://github.com/airbytehq/airbyte/pull/69154)   | Fix decimal validation                                                         |
 | 2.1.9      | 2025-10-30 | [69100](https://github.com/airbytehq/airbyte/pull/69100)   | Upgrade to CDK 0.1.61 to fix state index bug                                   |
 | 2.1.8      | 2025-10-28 | [68186](https://github.com/airbytehq/airbyte/pull/68186)   | Upgrade to CDK 0.1.59                                                          |
 | 2.1.7      | 2025-10-21 | [67153](https://github.com/airbytehq/airbyte/pull/67153)   | Implement new proto schema implementation                                      |