feat(source-hubspot): allow for a configured catalog to specify a user defined cursor field #69782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Contributor
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 98a699b. |
Contributor
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 task
Collaborator
|
/run-regression-tests
|
devin-ai-integration bot
added a commit
that referenced
this pull request
Nov 21, 2025
…fore running tests The regression test harness was failing with 'lstat /tmp/live_tests_artifacts: no such file or directory' when pytest failed early (before pytest_configure hook runs). Root cause: The /tmp/live_tests_artifacts directory is created by pytest's pytest_configure hook in conftest.py. However, if pytest fails to start (e.g., cloud-sql-proxy fails, poetry install fails), the hook never runs and the directory is never created. The airbyte-ci code then crashes when trying to check if the directory exists. Fix: Ensure the base /tmp/live_tests_artifacts directory exists in the container before running pytest. This allows the error handling code to run properly even if pytest fails early. This fix addresses the issue reported in PR #69782 where regression tests were failing with directory not found errors. Co-Authored-By: AJ Steers <[email protected]>
1 task
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
agarctfi
approved these changes
Dec 4, 2025
Contributor
|
Contributor
Author
|
/approve-regression-tests Run here: Looking over results. The record counts match, expected diff in the catalogs now that source_defined_cursor will be false for the affected streams since they support customer selecting the cursor. Record mismatches might be from run skew. Approving the results
|
darynaishchenko
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated to the latest CDK which allows for usage of the
allow_catalog_defined_cursor_fieldfield which enables a stream to support customers defining the cursor field when configuring their schema.The configured catalog will persist the custom
cursor_fieldand during a sync we will read thecursor_fieldfrom the configured catalog and use it when persisting state and extracting cursor values. If not defined, we fall back to the one defined on theincremental_synccomponent.Tested this on Cloud and seen the proper values reflected in the emitted state message
CDK PR with the feature:
airbytehq/airbyte-python-cdk#851