Skip to content

Commit 900b335

Browse files
authored
using generic H1 decoder instead of specific (#235)
1 parent e243d3e commit 900b335

File tree

2 files changed

+7
-53
lines changed

2 files changed

+7
-53
lines changed

lib/plugins/Label_H1_PWI.test.ts

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,21 @@
11
import { MessageDecoder } from '../MessageDecoder';
2-
import { Label_H1_PWI } from './Label_H1_PWI';
2+
import { Label_H1 } from './Label_H1';
33

4-
describe('Label_H1_PWI', () => {
5-
let plugin: Label_H1_PWI;
4+
describe('Label H1 PWI', () => {
5+
let plugin: Label_H1;
66

77
beforeEach(() => {
88
const decoder = new MessageDecoder();
9-
plugin = new Label_H1_PWI(decoder);
9+
plugin = new Label_H1(decoder);
1010
});
1111

12-
test('matches Label H1 Preamble PWI qualifiers', () => {
13-
expect(plugin.decode).toBeDefined();
14-
expect(plugin.name).toBe('label-h1-pwi');
15-
expect(plugin.qualifiers).toBeDefined();
16-
expect(plugin.qualifiers()).toEqual({
17-
labels: ['H1'],
18-
preambles: ['PWI'],
19-
});
20-
});
21-
2212

2313
test('decodes Label H1 Preamble PWI valid', () => {
2414
const text = 'PWI/WD390,COLZI,258070.AWYAT,252071.IPTAY,250065.CHOPZ,244069.MGMRY,234065.CATLN,230060/WD340,COLZI,256073,340M41.AWYAT,252070,340M41.IPTAY,244059,340M41.CHOPZ,240059,340M41.MGMRY,232056,340M41.CATLN,218053,340M40/WD300,COLZI,256065.AWYAT,254062.IPTAY,250051.CHOPZ,248050.MGMRY,232044.CATLN,222047/WD240,COLZI,260045.AWYAT,258048.IPTAY,254043.CHOPZ,256041.MGMRY,238035.CATLN,226034/DD300214059.240214040.180236024.100250018:,,,,/CB300246040.240246017.180226015.1002100080338'
2515
const decodeResult = plugin.decode({ text: text });
2616

2717
expect(decodeResult.decoded).toBe(true);
28-
expect(decodeResult.decoder.decodeLevel).toBe('full');
18+
expect(decodeResult.decoder.decodeLevel).toBe('partial');
2919
expect(decodeResult.formatted.items.length).toBe(25);
3020
expect(decodeResult.formatted.items[0].type).toBe('wind_data');
3121
expect(decodeResult.formatted.items[0].code).toBe('WIND');
@@ -37,6 +27,7 @@ describe('Label_H1_PWI', () => {
3727
expect(decodeResult.formatted.items[1].value).toBe('AWYAT at FL390: 252° at 71kt');
3828
expect(decodeResult.formatted.items[24].label).toBe('Message Checksum');
3929
expect(decodeResult.formatted.items[24].value).toBe('0x0338');
30+
expect(decodeResult.remaining.text).toBe('DD300214059.240214040.180236024.100250018:,,,,/CB300246040.240246017.180226015.100210008');
4031
});
4132

4233
test('decodes Label H1 Preamble POS <invalid>', () => {
@@ -46,7 +37,7 @@ describe('Label_H1_PWI', () => {
4637

4738
expect(decodeResult.decoded).toBe(false);
4839
expect(decodeResult.decoder.decodeLevel).toBe('none');
49-
expect(decodeResult.decoder.name).toBe('label-h1-pwi');
40+
expect(decodeResult.decoder.name).toBe('label-h1');
5041
expect(decodeResult.formatted.description).toBe('Weather Report');
5142
expect(decodeResult.message.text).toBe(text);
5243
});

lib/plugins/Label_H1_PWI.ts

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)