Make clippy happy again

Author: Folyd

.github/workflows/release.yaml

@@ -3,7 +3,7 @@ name: Release AIScript
 on:
   push:
     tags:
-      - "v*"
+      - 'v*'
 
 jobs:
   build:
@@ -62,6 +62,7 @@ jobs:
         with:
           name: ${{ matrix.asset_name }}
           path: dist/${{ matrix.asset_name }}
+          retention-days: 1
           if-no-files-found: error
 
   release:
@@ -90,19 +91,23 @@ jobs:
           find . -type f -not -path "*/\.*" | grep -v "checksums.txt" | xargs -I{} shasum -a 256 {} > checksums.txt
           cat checksums.txt
 
+      - name: Prepare release files
+        run: |
+          mkdir -p release_files
+          cp dist/aiscript-linux-x86_64/aiscript-linux-x86_64 release_files/
+          cp dist/aiscript-macos-x86_64/aiscript-macos-x86_64 release_files/
+          cp dist/aiscript-macos-arm64/aiscript-macos-arm64 release_files/
+          cp dist/aiscript-windows-x86_64.exe/aiscript-windows-x86_64.exe release_files/
+          cp dist/install.sh release_files/
+          cp dist/checksums.txt release_files/
+
       - name: Create release
         id: create_release
         uses: softprops/action-gh-release@v1
         with:
-          files: |
-            dist/aiscript-linux-x86_64/aiscript-linux-x86_64
-            dist/aiscript-macos-x86_64/aiscript-macos-x86_64
-            dist/aiscript-macos-arm64/aiscript-macos-arm64
-            dist/aiscript-windows-x86_64.exe/aiscript-windows-x86_64.exe
-            dist/install.sh
-            dist/checksums.txt
+          files: release_files/*
           draft: false
           prerelease: false
           generate_release_notes: true
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

aiscript-arena/src/collect.rs

@@ -19,6 +19,7 @@ use crate::context::Collection;
 /// deriving `Collect`. A safe way of providing internal mutability in this case is to use
 /// [`crate::lock::Lock<T>`] and [`crate::lock::RefLock<T>`], which provides internal mutability
 /// while ensuring that the write barrier is always executed.
+/// # Safety
 pub unsafe trait Collect {
     /// As an optimization, if this type can never hold a `Gc` pointer and `trace` is unnecessary
     /// to call, you may implement this method and return false. The default implementation returns

aiscript-arena/src/context.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::neg_cmp_op_on_partial_ord)]
 use alloc::{boxed::Box, vec::Vec};
 use core::{
     cell::{Cell, RefCell},

aiscript-arena/src/gc.rs

@@ -181,6 +181,7 @@ impl<'gc, T: ?Sized + 'gc> Gc<'gc, T> {
     ///
     /// Unlike `AsRef` or `Deref`, the returned reference isn't bound to the `Gc` itself, and
     /// will stay valid for the entirety of the current arena callback.
+    #[allow(clippy::should_implement_trait)]
     #[inline]
     pub fn as_ref(self: Gc<'gc, T>) -> &'gc T {
         // SAFETY: The returned reference cannot escape the current arena callback, as `&'gc T`
@@ -258,10 +259,6 @@ impl<'gc, T: PartialEq + ?Sized + 'gc> PartialEq for Gc<'gc, T> {
     fn eq(&self, other: &Self) -> bool {
         (**self).eq(other)
     }
-
-    fn ne(&self, other: &Self) -> bool {
-        (**self).ne(other)
-    }
 }
 
 impl<'gc, T: Eq + ?Sized + 'gc> Eq for Gc<'gc, T> {}