fix(kafka_topic): pass server errors to basic controller for proper retries (#1014)

Author: vmyroslav

.github/workflows/tests.yml

@@ -53,7 +53,8 @@ jobs:
           go-version-file: go.mod
       - run: make test-tag tag=${{ matrix.name }}
         env:
-          AIVEN_DEBUG: ${{ secrets.AIVEN_DEBUG }}
+          AIVEN_DEBUG: ${{ vars.AIVEN_DEBUG || 'false' }}
+          ENABLE_DEBUG_LOGGING: ${{ vars.ENABLE_DEBUG_LOGGING || 'false' }}
           AIVEN_TOKEN: ${{ secrets.AIVEN_TOKEN }}
           AIVEN_ACCOUNT_ID: ${{ secrets.AIVEN_ACCOUNT_ID }}
           AIVEN_PROJECT_NAME: >-

controllers/kafkatopic_controller.go

@@ -91,12 +91,8 @@ func (h KafkaTopicHandler) createOrUpdate(ctx context.Context, avnGen avngen.Cli
 		}
 	}
 
-	switch {
-	case isServerError(err):
-		// Service is not ready yet, retry later.
-		return nil
-	case err != nil:
-		return err
+	if err != nil {
+		return fmt.Errorf("failed to create Kafka Topic: %w", err)
 	}
 
 	return nil

controllers/serviceuser_controller.go

@@ -158,6 +158,9 @@ func (h *ServiceUserHandler) get(ctx context.Context, avnGen avngen.Client, obj
 		// Outer controller must be able to detect error types like "server error".
 		retry.LastErrorOnly(true),
 	)
+	if err != nil {
+		return nil, err
+	}
 
 	s, err := avnGen.ServiceGet(ctx, user.Spec.Project, user.Spec.ServiceName)
 	if err != nil {