Replace "Warning reason" with "Tip message"

Author: mini-bomba

src/routes/postSkipSegments.ts

@@ -179,7 +179,7 @@ async function checkUserActiveWarning(userID: HashedUserID): Promise<CheckResult
 
         return {
             pass: false,
-            errorMessage: defaultMessage + (warnings[0]?.reason?.length > 0 ? `\n\nWarning reason: '${warnings[0].reason}'` : ""),
+            errorMessage: defaultMessage + (warnings[0]?.reason?.length > 0 ? `\n\nTip message: '${warnings[0].reason}'` : ""),
             errorCode: 403
         };
     }

src/routes/voteOnSponsorTime.ts

@@ -384,7 +384,7 @@ export async function vote(ip: IPAddress, UUID: SegmentUUID, paramUserID: UserID
         lock.unlock();
         return { status: 403, message: "Vote rejected due to a tip from a moderator. This means that we noticed you were making some common mistakes that are not malicious, and we just want to clarify the rules. " +
                 "Could you please send a message in Discord or Matrix so we can further help you?" +
-                `${(warningReason.length > 0 ? ` Warning reason: '${warningReason}'` : "")}` };
+                `${(warningReason.length > 0 ? ` Tip message: '${warningReason}'` : "")}` };
     }
 
     // we can return out of the function early if the user is banned after warning checks

test/cases/postSkipSegmentsWarnings.ts

@@ -63,7 +63,7 @@ describe("postSkipSegments Warnings", () => {
                 const expected = "Submission rejected due to a tip from a moderator. This means that we noticed you were making some common mistakes"
                 + " that are not malicious, and we just want to clarify the rules. "
                 + "Could you please send a message in discord.gg/SponsorBlock or matrix.to/#/#sponsor:ajay.app so we can further help you? "
-                + `Your userID is ${warnUser01Hash}.\n\nWarning reason: '${reason}'`;
+                + `Your userID is ${warnUser01Hash}.\n\nTip message: '${reason}'`;
 
                 assert.strictEqual(errorMessage, expected);
                 done();