Skip to content

Commit 96db571

Browse files
committed
Fix request rate limit option not working
1 parent ccd1321 commit 96db571

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ function setupRoutes(router: Router) {
8080
// Rate limit endpoint lists
8181
const voteEndpoints: RequestHandler[] = [voteOnSponsorTime];
8282
const viewEndpoints: RequestHandler[] = [viewedVideoSponsorTime];
83-
if (config.rateLimit) {
83+
if (config.rateLimit && config.redisRateLimit) {
8484
if (config.rateLimit.vote) voteEndpoints.unshift(rateLimitMiddleware(config.rateLimit.vote, voteGetUserID));
8585
if (config.rateLimit.view) viewEndpoints.unshift(rateLimitMiddleware(config.rateLimit.view));
8686
}

src/middleware/requestRateLimit.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ export function rateLimitMiddleware(limitConfig: RateLimitConfig, getUserID?: (r
3232
}
3333
},
3434
store: config.redis?.enabled ? new RedisStore({
35-
sendCommand: (...args: string[]) => config.redisRateLimit ? redis.sendCommand(args).catch((err) => Logger.error(err)) as Promise<RedisReply>
36-
: Promise.resolve(null) as Promise<RedisReply>,
35+
sendCommand: (...args: string[]) => redis.sendCommand(args).catch((err) => Logger.error(err)) as Promise<RedisReply>,
3736
}) : null,
3837
});
3938
} catch (e) {

0 commit comments

Comments
 (0)