Reject unsupported services

Author: BANOnotIT

src/routes/postSkipSegments.ts

@@ -17,7 +17,7 @@ import { HashedUserID, UserID } from "../types/user.model";
 import { isUserVIP } from "../utils/isUserVIP";
 import { isUserTempVIP } from "../utils/isUserTempVIP";
 import { parseUserAgent } from "../utils/userAgent";
-import { getService } from "../utils/getService";
+import { getService, getUnsupportedService } from "../utils/getService";
 import axios from "axios";
 import { vote } from "./voteOnSponsorTime";
 import { canSubmit } from "../utils/permissions";
@@ -500,6 +500,11 @@ export async function postSkipSegments(req: Request, res: Response): Promise<Res
         proxySubmission(req);
     }
 
+    const unsupportedValue = getUnsupportedService(req.query.service, req.body.service)
+    if (unsupportedValue) {
+        return res.status(400).send(`Service is not supported: ${unsupportedValue}`);
+    }
+
     // eslint-disable-next-line prefer-const
     let { videoID, userID: paramUserID, service, videoDuration, videoDurationParam, segments, userAgent } = preprocessInput(req);
 

src/utils/getService.ts

@@ -15,3 +15,22 @@ export function getService<T extends string>(...value: T[]): Service {
 
     return Service.YouTube;
 }
+
+export function getUnsupportedService<T extends string>(...value: T[]): string | undefined {
+    const serviceByName = Object.values(Service).reduce((acc, serviceName) => {
+        acc[serviceName.toLowerCase()] = serviceName;
+
+        return acc;
+    }, {} as Record<string, Service>);
+
+    let unsupportedValue;
+    for (const name of value) {
+        const cleanName = name?.trim().toLowerCase()
+        if (cleanName in serviceByName) {
+            return null
+        }
+        if(cleanName) unsupportedValue = name
+    }
+
+    return unsupportedValue
+}

test/cases/postSkipSegments.ts

@@ -351,6 +351,24 @@ describe("postSkipSegments", () => {
             .catch(err => done(err));
     });
 
+    it("Should not be able to submit with unknown service", (done) => {
+        const videoID = "colon-1";
+        postSkipSegmentJSON({
+            userID: submitUserOne,
+            videoID,
+            service:"Unsupported-xxx",
+            segments: [{
+                segment: ["0", "3"],
+                category: "sponsor",
+            }]
+        })
+            .then(res => {
+                assert.strictEqual(res.status, 400);
+                done();
+            })
+            .catch(err => done(err));
+    });
+
     it("Should throw 409 on duplicate submission", (done) => {
         const videoID = "private-video";
         postSkipSegmentParam({