Better chapter name error and increase min size

ajayyy · ajayyy · commit ec41102f07af · 2022-09-04T22:36:26.000-04:00
diff --git a/src/routes/postSkipSegments.ts b/src/routes/postSkipSegments.ts
@@ -227,11 +227,14 @@ async function checkInvalidFields(videoID: VideoID, userID: UserID, hashedUserID
         }
 
         if (typeof segmentPair.description !== "string"
-                || (segmentPair.actionType === ActionType.Chapter && segmentPair.description.length > 60 )
                 || (segmentPair.description.length !== 0 && segmentPair.actionType !== ActionType.Chapter)) {
             invalidFields.push("segment description");
         }
 
+        if (segmentPair.actionType === ActionType.Chapter && segmentPair.description.length > 200) {
+            invalidFields.push("chapter name (too long)");
+        }
+
         const permission = await canSubmit(hashedUserID, segmentPair.category);
         if (!permission.canSubmit) {
             Logger.warn(`Rejecting submission due to lack of permissions for category ${segmentPair.category}: ${segmentPair.segment} ${hashedUserID} ${videoID} ${videoDurationParam} ${userAgent}`);

Original file line number	Diff line number	Diff line change
`@@ -227,11 +227,14 @@ async function checkInvalidFields(videoID: VideoID, userID: UserID, hashedUserID`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`if (typeof segmentPair.description !== "string"`
`230`		`- \|\| (segmentPair.actionType === ActionType.Chapter && segmentPair.description.length > 60 )`
`231`	`230`	`\|\| (segmentPair.description.length !== 0 && segmentPair.actionType !== ActionType.Chapter)) {`
`232`	`231`	`invalidFields.push("segment description");`
`233`	`232`	`}`
`234`	`233`
	`234`	`+ if (segmentPair.actionType === ActionType.Chapter && segmentPair.description.length > 200) {`
	`235`	`+ invalidFields.push("chapter name (too long)");`
	`236`	`+ }`
	`237`	`+`
`235`	`238`	`const permission = await canSubmit(hashedUserID, segmentPair.category);`
`236`	`239`	`if (!permission.canSubmit) {`
`237`	`240`	Logger.warn(`Rejecting submission due to lack of permissions for category ${segmentPair.category}: ${segmentPair.segment} ${hashedUserID} ${videoID} ${videoDurationParam} ${userAgent}`);