Skip to content

Don't downcast PROMPT_COMMAND #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't downcast PROMPT_COMMAND #1036

wants to merge 2 commits into from

Conversation

SuperSandro2000
Copy link

@SuperSandro2000 SuperSandro2000 commented Apr 8, 2025 •
edited
Loading

Since bash 5.0 PROMPT_COMMAND is an array. Lets not turn it into a string. Copied from https://github.com/direnv/direnv/blob/master/internal/cmd/shell_bash.go#L19-L23

Tested with an overlay in my nixos config.

@SuperSandro2000
Don't downcast PROMPT_COMMAND
a88bb34 
Since bash 5.0 PROMPT_COMMAND is an array. Lets not turn it into a string.
Copied from https://github.com/direnv/direnv/blob/master/internal/cmd/shell_bash.go#L19-L23
@SuperSandro2000
Fix linting
d28af07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@azaleacolburn azaleacolburn azaleacolburn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @azaleacolburn