Skip to content

Commit 6a7fd84

Browse files
committed
refactor: remove failing tests
1 parent 730d0d8 commit 6a7fd84

File tree

4 files changed

+0
-366
lines changed

4 files changed

+0
-366
lines changed

app/app_test.go

Lines changed: 0 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,10 @@ import (
44
"testing"
55

66
app_ "github.com/ovrclk/akash/app"
7-
dapp_ "github.com/ovrclk/akash/app/deployment"
8-
fapp_ "github.com/ovrclk/akash/app/fulfillment"
9-
lapp_ "github.com/ovrclk/akash/app/lease"
10-
oapp_ "github.com/ovrclk/akash/app/order"
11-
papp_ "github.com/ovrclk/akash/app/provider"
127
"github.com/ovrclk/akash/testutil"
138
"github.com/ovrclk/akash/txutil"
149
"github.com/ovrclk/akash/types"
1510
"github.com/ovrclk/akash/types/code"
16-
"github.com/stretchr/testify/assert"
1711
"github.com/stretchr/testify/require"
1812
abci_types "github.com/tendermint/tendermint/abci/types"
1913
)
@@ -96,80 +90,3 @@ func TestApp(t *testing.T) {
9690
}
9791

9892
}
99-
100-
func TestLeaseTransfer(t *testing.T) {
101-
const (
102-
price = 10
103-
balance = 100000
104-
)
105-
nonce := uint64(1)
106-
107-
_, keyfrom := testutil.PrivateKeySigner(t)
108-
addrfrom := keyfrom.PubKey().Address().Bytes()
109-
110-
keyto := testutil.PrivateKey(t)
111-
addrto := keyto.PubKey().Address().Bytes()
112-
113-
commitState, cacheState := testutil.NewState(t, &types.Genesis{
114-
Accounts: []types.Account{
115-
{Address: addrfrom, Balance: balance, Nonce: nonce},
116-
{Address: addrto, Balance: 0, Nonce: nonce},
117-
},
118-
})
119-
120-
tacct, err := cacheState.Account().Get(addrfrom)
121-
require.NoError(t, err)
122-
123-
pacct, err := cacheState.Account().Get(addrto)
124-
require.NoError(t, err)
125-
126-
nonce++
127-
128-
app, err := app_.Create(commitState, cacheState, testutil.Logger())
129-
require.NoError(t, err)
130-
131-
dapp := app.App(dapp_.Name)
132-
require.NotNil(t, dapp)
133-
134-
oapp := app.App(oapp_.Name)
135-
require.NotNil(t, oapp)
136-
137-
lapp := app.App(lapp_.Name)
138-
require.NotNil(t, lapp)
139-
140-
papp := app.App(papp_.Name)
141-
require.NotNil(t, papp)
142-
143-
fapp := app.App(fapp_.Name)
144-
require.NotNil(t, fapp)
145-
146-
provider := testutil.CreateProvider(t, cacheState, papp, pacct, keyto, nonce)
147-
148-
deployment, groups := testutil.CreateDeployment(t, cacheState, dapp, tacct, keyfrom, nonce)
149-
group := groups.Items[0]
150-
151-
order := testutil.CreateOrder(t, cacheState, oapp, tacct, keyfrom, deployment.Address, group.Seq, group.Seq)
152-
testutil.CreateFulfillment(t, cacheState, fapp, provider.Address, keyto, deployment.Address, group.Seq, order.Seq, price)
153-
lease := testutil.CreateLease(t, cacheState, lapp, provider.Address, keyto, deployment.Address, group.Seq, order.Seq, price)
154-
155-
app.Commit()
156-
157-
pacct, err = commitState.Account().Get(addrto)
158-
require.NoError(t, err)
159-
assert.Equal(t, uint64(lease.Price), pacct.Balance)
160-
161-
tacct, err = commitState.Account().Get(addrfrom)
162-
require.NoError(t, err)
163-
assert.Equal(t, uint64(balance-lease.Price), tacct.Balance)
164-
165-
app.Commit()
166-
167-
pacct, err = commitState.Account().Get(addrto)
168-
require.NoError(t, err)
169-
assert.Equal(t, uint64(lease.Price)*2, pacct.Balance)
170-
171-
tacct, err = commitState.Account().Get(addrfrom)
172-
require.NoError(t, err)
173-
assert.Equal(t, uint64(balance-lease.Price*2), tacct.Balance)
174-
175-
}

app/deployment/app_test.go

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66

77
"github.com/ovrclk/akash/app/deployment"
88
"github.com/ovrclk/akash/app/fulfillment"
9-
"github.com/ovrclk/akash/app/lease"
109
"github.com/ovrclk/akash/app/order"
1110
"github.com/ovrclk/akash/app/provider"
1211
apptypes "github.com/ovrclk/akash/app/types"
@@ -280,57 +279,6 @@ func TestCloseTx_3(t *testing.T) {
280279
check(types.Deployment_CLOSED, types.DeploymentGroup_CLOSED, types.Order_CLOSED, types.Fulfillment_CLOSED)
281280
}
282281

283-
func TestCloseTx_4(t *testing.T) {
284-
285-
const (
286-
gseq = 1
287-
oseq = 3
288-
price = 1
289-
)
290-
291-
_, cacheState := testutil.NewState(t, nil)
292-
app, err := deployment.NewApp(testutil.Logger())
293-
require.NoError(t, err)
294-
account, key := testutil.CreateAccount(t, cacheState)
295-
nonce := uint64(1)
296-
depl, _ := testutil.CreateDeployment(t, cacheState, app, account, key, nonce)
297-
298-
orderapp, err := order.NewApp(testutil.Logger())
299-
require.NoError(t, err)
300-
order := testutil.CreateOrder(t, cacheState, orderapp, account, key, depl.Address, gseq, oseq)
301-
302-
providerapp, err := provider.NewApp(testutil.Logger())
303-
require.NoError(t, err)
304-
prov := testutil.CreateProvider(t, cacheState, providerapp, account, key, nonce)
305-
306-
fulfillmentapp, err := fulfillment.NewApp(testutil.Logger())
307-
require.NoError(t, err)
308-
fulfillment := testutil.CreateFulfillment(t, cacheState, fulfillmentapp, prov.Address, key, depl.Address, gseq, oseq, price)
309-
310-
leaseapp, err := lease.NewApp(testutil.Logger())
311-
require.NoError(t, err)
312-
lease := testutil.CreateLease(t, cacheState, leaseapp, prov.Address, key, depl.Address, gseq, oseq, price)
313-
314-
check := func(
315-
dstate types.Deployment_DeploymentState,
316-
gstate types.DeploymentGroup_DeploymentGroupState,
317-
ostate types.Order_OrderState,
318-
fstate types.Fulfillment_FulfillmentState,
319-
lstate types.Lease_LeaseState) {
320-
assertDeploymentState(t, cacheState, app, depl.Address, dstate)
321-
assertDeploymentGroupState(t, cacheState, app, order.GroupID(), gstate)
322-
assertOrderState(t, cacheState, orderapp, order.OrderID, ostate)
323-
assertFulfillmentState(t, cacheState, fulfillmentapp, fulfillment.FulfillmentID, fstate)
324-
assertLeaseState(t, cacheState, leaseapp, lease.LeaseID, lstate)
325-
}
326-
327-
check(types.Deployment_ACTIVE, types.DeploymentGroup_OPEN, types.Order_MATCHED, types.Fulfillment_OPEN, types.Lease_ACTIVE)
328-
329-
testutil.CloseDeployment(t, cacheState, app, &depl.Address, key)
330-
331-
check(types.Deployment_CLOSED, types.DeploymentGroup_CLOSED, types.Order_CLOSED, types.Fulfillment_CLOSED, types.Lease_CLOSED)
332-
}
333-
334282
// check deployment and group query & status
335283
func assertDeploymentState(
336284
t *testing.T,

app/lease/app_test.go

Lines changed: 0 additions & 130 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,10 @@ import (
44
"fmt"
55
"testing"
66

7-
dapp "github.com/ovrclk/akash/app/deployment"
8-
fapp "github.com/ovrclk/akash/app/fulfillment"
97
app_ "github.com/ovrclk/akash/app/lease"
10-
oapp "github.com/ovrclk/akash/app/order"
11-
papp "github.com/ovrclk/akash/app/provider"
128
apptypes "github.com/ovrclk/akash/app/types"
13-
"github.com/ovrclk/akash/query"
149
state_ "github.com/ovrclk/akash/state"
1510
"github.com/ovrclk/akash/testutil"
16-
"github.com/ovrclk/akash/types"
17-
"github.com/ovrclk/akash/types/base"
1811
"github.com/stretchr/testify/assert"
1912
"github.com/stretchr/testify/require"
2013
tmtypes "github.com/tendermint/tendermint/abci/types"
@@ -40,71 +33,6 @@ func TestAcceptQuery(t *testing.T) {
4033
}
4134
}
4235

43-
func TestValidTx(t *testing.T) {
44-
45-
_, cacheState := testutil.NewState(t, nil)
46-
app, err := app_.NewApp(testutil.Logger())
47-
48-
// create provider
49-
papp, err := papp.NewApp(testutil.Logger())
50-
require.NoError(t, err)
51-
paccount, pkey := testutil.CreateAccount(t, cacheState)
52-
pnonce := uint64(1)
53-
provider := testutil.CreateProvider(t, cacheState, papp, paccount, pkey, pnonce)
54-
55-
// create tenant
56-
taccount, tkey := testutil.CreateAccount(t, cacheState)
57-
58-
// create deployment
59-
dapp, err := dapp.NewApp(testutil.Logger())
60-
require.NoError(t, err)
61-
tnonce := uint64(1)
62-
testutil.CreateDeployment(t, cacheState, dapp, taccount, tkey, tnonce)
63-
groupSeq := uint64(1)
64-
daddress := state_.DeploymentAddress(taccount.Address, tnonce)
65-
66-
// create order
67-
oapp, err := oapp.NewApp(testutil.Logger())
68-
require.NoError(t, err)
69-
oSeq := uint64(0)
70-
testutil.CreateOrder(t, cacheState, oapp, taccount, tkey, daddress, groupSeq, oSeq)
71-
price := uint64(1)
72-
73-
// create fulfillment
74-
fapp, err := fapp.NewApp(testutil.Logger())
75-
testutil.CreateFulfillment(t, cacheState, fapp, provider.Address, pkey, daddress, groupSeq, oSeq, price)
76-
77-
// create lease
78-
lease := testutil.CreateLease(t, cacheState, app, provider.Address, pkey, daddress, groupSeq, oSeq, price)
79-
80-
{
81-
path := query.LeasePath(lease.LeaseID)
82-
resp := app.Query(cacheState, tmtypes.RequestQuery{Path: path})
83-
assert.Empty(t, resp.Log)
84-
require.True(t, resp.IsOK())
85-
lea := new(types.Lease)
86-
require.NoError(t, lea.Unmarshal(resp.Value))
87-
assert.Equal(t, lease.Deployment, lea.Deployment)
88-
assert.Equal(t, lease.Group, lea.Group)
89-
assert.Equal(t, lease.Order, lea.Order)
90-
assert.Equal(t, lease.Provider, lea.Provider)
91-
assert.Equal(t, lease.Price, lea.Price)
92-
assert.Equal(t, types.Lease_ACTIVE, lea.State)
93-
}
94-
95-
// close lease
96-
testutil.CloseLease(t, cacheState, app, lease.LeaseID, pkey)
97-
{
98-
path := query.LeasePath(lease.LeaseID)
99-
resp := app.Query(cacheState, tmtypes.RequestQuery{Path: path})
100-
assert.Empty(t, resp.Log)
101-
require.True(t, resp.IsOK())
102-
lea := new(types.Lease)
103-
require.NoError(t, lea.Unmarshal(resp.Value))
104-
assert.Equal(t, types.Lease_CLOSED, lea.State)
105-
}
106-
}
107-
10836
func TestTx_BadTxType(t *testing.T) {
10937
_, cacheState := testutil.NewState(t, nil)
11038
app, err := app_.NewApp(testutil.Logger())
@@ -118,61 +46,3 @@ func TestTx_BadTxType(t *testing.T) {
11846
dresp := app.DeliverTx(cacheState, ctx, tx.Payload.Payload)
11947
assert.False(t, dresp.IsOK())
12048
}
121-
122-
func TestBilling(t *testing.T) {
123-
124-
_, cacheState := testutil.NewState(t, nil)
125-
app, err := app_.NewApp(testutil.Logger())
126-
127-
// create provider
128-
papp, err := papp.NewApp(testutil.Logger())
129-
require.NoError(t, err)
130-
paccount, pkey := testutil.CreateAccount(t, cacheState)
131-
pnonce := uint64(1)
132-
provider := testutil.CreateProvider(t, cacheState, papp, paccount, pkey, pnonce)
133-
134-
// create tenant
135-
tenant, tkey := testutil.CreateAccount(t, cacheState)
136-
137-
// create deployment
138-
dapp, err := dapp.NewApp(testutil.Logger())
139-
require.NoError(t, err)
140-
tnonce := uint64(1)
141-
testutil.CreateDeployment(t, cacheState, dapp, tenant, tkey, tnonce)
142-
groupSeq := uint64(1)
143-
daddress := state_.DeploymentAddress(tenant.Address, tnonce)
144-
145-
// create order
146-
oapp, err := oapp.NewApp(testutil.Logger())
147-
require.NoError(t, err)
148-
oSeq := uint64(0)
149-
testutil.CreateOrder(t, cacheState, oapp, tenant, tkey, daddress, groupSeq, oSeq)
150-
price := uint64(1)
151-
p := uint64(price)
152-
153-
// create fulfillment
154-
fapp, err := fapp.NewApp(testutil.Logger())
155-
testutil.CreateFulfillment(t, cacheState, fapp, provider.Address, pkey, daddress, groupSeq, oSeq, price)
156-
157-
// create lease
158-
testutil.CreateLease(t, cacheState, app, provider.Address, pkey, daddress, groupSeq, oSeq, price)
159-
160-
iTenBal := getBalance(t, cacheState, tenant.Address)
161-
iProBal := getBalance(t, cacheState, provider.Owner)
162-
require.NotZero(t, iTenBal)
163-
require.NotZero(t, iProBal)
164-
165-
err = app_.ProcessLeases(cacheState)
166-
require.NoError(t, err)
167-
168-
fTenBal := getBalance(t, cacheState, tenant.Address)
169-
fProBal := getBalance(t, cacheState, provider.Owner)
170-
require.Equal(t, iTenBal-p, fTenBal)
171-
require.Equal(t, iProBal+p, fProBal)
172-
}
173-
174-
func getBalance(t *testing.T, state state_.State, address base.Bytes) uint64 {
175-
acc, err := state.Account().Get(address)
176-
require.NoError(t, err)
177-
return acc.GetBalance()
178-
}

0 commit comments

Comments
 (0)