feat: prevent duplicate bids

fixes #534

Author: boz

x/market/handler/handler.go

@@ -45,9 +45,9 @@ func handleMsgCreateBid(ctx sdk.Context, keepers Keepers, msg types.MsgCreateBid
 		return nil, types.ErrAtributeMismatch
 	}
 
-	// TODO: ensure not a current bid from this provider
-
-	keepers.Market.CreateBid(ctx, msg.Order, msg.Provider, msg.Price)
+	if _, err := keepers.Market.CreateBid(ctx, msg.Order, msg.Provider, msg.Price); err != nil {
+		return nil, err
+	}
 
 	return &sdk.Result{
 		Events: ctx.EventManager().Events(),

x/market/keeper/keeper.go

@@ -68,7 +68,7 @@ func (k Keeper) CreateOrder(ctx sdk.Context, gid dtypes.GroupID, spec dtypes.Gro
 }
 
 // CreateBid creates a bid for a order with given orderID, price for bid and provider
-func (k Keeper) CreateBid(ctx sdk.Context, oid types.OrderID, provider sdk.AccAddress, price sdk.Coin) {
+func (k Keeper) CreateBid(ctx sdk.Context, oid types.OrderID, provider sdk.AccAddress, price sdk.Coin) (types.Bid, error) {
 
 	store := ctx.KVStore(k.skey)
 
@@ -80,6 +80,10 @@ func (k Keeper) CreateBid(ctx sdk.Context, oid types.OrderID, provider sdk.AccAd
 
 	key := bidKey(bid.ID())
 
+	if store.Has(key) {
+		return types.Bid{}, types.ErrBidExists
+	}
+
 	// XXX TODO: check not overwrite
 	store.Set(key, k.cdc.MustMarshalBinaryBare(bid))
 
@@ -89,6 +93,8 @@ func (k Keeper) CreateBid(ctx sdk.Context, oid types.OrderID, provider sdk.AccAd
 			Price: price,
 		}.ToSDKEvent(),
 	)
+
+	return bid, nil
 }
 
 // CreateLease creates lease for bid with given bidID

x/market/simulation/operations.go

@@ -1,6 +1,7 @@
 package simulation
 
 import (
+	"errors"
 	"fmt"
 	"math/rand"
 
@@ -122,11 +123,15 @@ func SimulateMsgCreateBid(ak govtypes.AccountKeeper, ks keepers.Keepers) simulat
 		)
 
 		_, _, err = app.Deliver(tx)
-		if err != nil {
+		switch {
+		case err == nil:
+			return simulation.NewOperationMsg(msg, true, ""), nil, nil
+		case errors.Is(err, types.ErrBidExists):
+			return simulation.NewOperationMsg(msg, false, ""), nil, nil
+		default:
 			return simulation.NoOpMsg(types.ModuleName), nil, err
 		}
 
-		return simulation.NewOperationMsg(msg, true, ""), nil, nil
 	}
 }
 

x/market/types/errors.go

@@ -37,4 +37,6 @@ var (
 	ErrBidNotFound = sdkerrors.Register(ModuleName, 15, "invalid bid: bid not found")
 	// ErrLeaseNotFound lease not found
 	ErrLeaseNotFound = sdkerrors.Register(ModuleName, 16, "invalid lease: lease not found")
+	// ErrBidExists bid exists
+	ErrBidExists = sdkerrors.Register(ModuleName, 17, "invalid bid: bid exists from provider")
 )