Skip to content

Commit e3888af

Browse files
committed
fix(upgrade): use preupgrade store prefixes from migrate package
Signed-off-by: Artur Troian <[email protected]>
1 parent 70aa0ec commit e3888af

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

upgrades/software/v1.0.0/deployment.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ func (m deploymentsMigrations) GetHandler() sdkmodule.MigrationHandler {
3232
func (m deploymentsMigrations) handler(ctx sdk.Context) error {
3333
store := ctx.KVStore(m.StoreKey())
3434

35+
// deployment prefix does not change in this upgrade
3536
oStore := prefix.NewStore(store, dkeeper.DeploymentPrefix)
3637

3738
iter := oStore.Iterator(nil, nil)
@@ -66,6 +67,7 @@ func (m deploymentsMigrations) handler(ctx sdk.Context) error {
6667
store.Set(key, bz)
6768
}
6869

70+
// group prefix does not change in this upgrade
6971
oStore = prefix.NewStore(store, dkeeper.GroupPrefix)
7072

7173
iter = oStore.Iterator(nil, nil)

upgrades/software/v1.0.0/market.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ func (m marketMigrations) handler(ctx sdk.Context) error {
3535

3636
cdc := m.Codec()
3737

38+
// order prefix does not change in this upgrade
3839
oiter := storetypes.KVStorePrefixIterator(store, mkeys.OrderPrefix)
3940
defer func() {
4041
_ = oiter.Close()
@@ -69,8 +70,8 @@ func (m marketMigrations) handler(ctx sdk.Context) error {
6970
store.Set(key, bz)
7071
}
7172

73+
// bid prefixes do not change in this upgrade
7274
store.Delete(mkeys.BidPrefixReverse)
73-
7475
biter := storetypes.KVStorePrefixIterator(store, mkeys.BidPrefix)
7576
defer func() {
7677
_ = biter.Close()
@@ -124,6 +125,7 @@ func (m marketMigrations) handler(ctx sdk.Context) error {
124125
}
125126
}
126127

128+
// lease prefixes do not change in this upgrade
127129
store.Delete(mkeys.LeasePrefixReverse)
128130
liter := storetypes.KVStorePrefixIterator(store, mkeys.LeasePrefix)
129131
defer func() {

upgrades/software/v1.0.0/provider.go

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
package v1_0_0
44

55
import (
6-
"cosmossdk.io/store/prefix"
6+
"fmt"
7+
78
sdk "github.com/cosmos/cosmos-sdk/types"
9+
"github.com/cosmos/cosmos-sdk/types/address"
810
sdkmodule "github.com/cosmos/cosmos-sdk/types/module"
911
"pkg.akt.dev/go/node/migrate"
10-
types "pkg.akt.dev/go/node/provider/v1beta4"
1112
"pkg.akt.dev/go/sdkutil"
1213

1314
utypes "pkg.akt.dev/node/upgrades/types"
@@ -26,10 +27,13 @@ func (m providerMigrations) GetHandler() sdkmodule.MigrationHandler {
2627
return m.handler
2728
}
2829

30+
func ProviderKey(id sdk.Address) []byte {
31+
return address.MustLengthPrefix(id.Bytes())
32+
}
33+
2934
// handler migrates provider store from version 2 to 3.
3035
func (m providerMigrations) handler(ctx sdk.Context) (err error) {
3136
store := ctx.KVStore(m.StoreKey())
32-
pstore := prefix.NewStore(store, types.ProviderPrefix())
3337

3438
iter := store.Iterator(nil, nil)
3539
defer func() {
@@ -38,15 +42,24 @@ func (m providerMigrations) handler(ctx sdk.Context) (err error) {
3842

3943
cdc := m.Codec()
4044

45+
var providersTotal uint64
46+
4147
for ; iter.Valid(); iter.Next() {
4248
to := migrate.ProviderFromV1beta3(cdc, iter.Value())
4349

4450
id := sdkutil.MustAccAddressFromBech32(to.Owner)
4551
bz := cdc.MustMarshal(&to)
4652

53+
providersTotal++
54+
4755
store.Delete(iter.Key())
48-
pstore.Set(pkeeper.ProviderKey(id), bz)
56+
store.Set(pkeeper.ProviderKey(id), bz)
4957
}
5058

59+
ctx.Logger().Info(fmt.Sprintf("[upgrade %s]: updated x/deployment store keys:"+
60+
"\n\tproviders total: %d",
61+
UpgradeName,
62+
providersTotal))
63+
5164
return nil
5265
}

0 commit comments

Comments
 (0)