fixed #34

Author: denisdulici

composer.json

@@ -22,8 +22,8 @@
         }
     ],
     "require": {
-        "php": ">=5.6.4",
-        "laravel/framework": ">=5.4",
+        "php": ">=7.0",
+        "laravel/framework": ">=5.5",
         "guzzlehttp/guzzle": ">=6.0",
         "jenssegers/agent": "2.6.*"
     },

src/Listeners/NotifyUsers.php

@@ -3,10 +3,8 @@
 namespace Akaunting\Firewall\Listeners;
 
 use Akaunting\Firewall\Events\AttackDetected as Event;
-use Akaunting\Firewall\Notifications\AttackDetected as Notification;
-use Exception;
-use GuzzleHttp\Exception\RequestException;
-use Illuminate\Notifications\Notifiable;
+use Akaunting\Firewall\Notifications\AttackDetected;
+use Akaunting\Firewall\Notifications\Notifiable;
 use Throwable;
 
 class NotifyUsers
@@ -20,34 +18,10 @@ class NotifyUsers
      */
     public function handle(Event $event)
     {
-        $notifiable = $this->getNotifiableClass();
-
         try {
-            $notifiable->notify(new Notification($event->log));
-        } catch (Exception | RequestException | Throwable $e) {
+            (new Notifiable)->notify(new AttackDetected($event->log));
+        } catch (Throwable $e) {
             report($e);
         }
     }
-
-    protected function getNotifiableClass()
-    {
-        return new class() {
-            use Notifiable;
-
-            public function routeNotificationForMail()
-            {
-                return config('firewall.notifications.mail.to');
-            }
-
-            public function routeNotificationForSlack()
-            {
-                return config('firewall.notifications.slack.to');
-            }
-
-            public function getKey()
-            {
-                return 1;
-            }
-        };
-    }
 }

src/Notifications/Notifiable.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Akaunting\Firewall\Notifications;
+
+use Illuminate\Notifications\Notifiable as NotifiableTrait;
+
+class Notifiable
+{
+    use NotifiableTrait;
+
+    public function routeNotificationForMail()
+    {
+        return config('firewall.notifications.mail.to');
+    }
+
+    public function routeNotificationForSlack()
+    {
+        return config('firewall.notifications.slack.to');
+    }
+
+    public function getKey()
+    {
+        return 1;
+    }
+}