Fix tests for phpunit 8

Author: pchasle

phpunit.xml.dist

@@ -8,10 +8,9 @@
      convertNoticesToExceptions="true"
      convertWarningsToExceptions="true"
      processIsolation="false"
-     stopOnFailure="false"
-     syntaxCheck="false">
+     stopOnFailure="false">
 
-    <testsuite>
+    <testsuite name="Integration">
         <directory>tests/</directory>
     </testsuite>
 

tests/Api/ApiTestCase.php

@@ -23,7 +23,7 @@ abstract class ApiTestCase extends TestCase
     /**
      * {@inheritdoc}
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->server = new MockWebServer(8081, '127.0.0.1');
         $this->server->start();
@@ -39,7 +39,7 @@ protected function setUp()
     /**
      * {@inheritdoc}
      */
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->server->stop();
     }

tests/Api/CreateProductTest.php

@@ -27,19 +27,18 @@ public function test_create_product()
         Assert::assertSame(201, $response);
     }
 
-    /**
-     * @expectedException \Akeneo\Pim\ApiClient\Exception\UnprocessableEntityHttpException
-     * @expectedExceptionMessage The value black_sneakers is already set on another product for the unique attribute sku
-     */
     public function test_create_invalid_product()
     {
         $this->server->setResponseOfPath(
             '/'. ProductApi::PRODUCTS_URI,
             new ResponseStack(
                 new Response('{"code": 422, "message":"The value black_sneakers is already set on another product for the unique attribute sku"}', [], 422)
-            )
-        );
-
+                )
+            );
+            
+        $this->expectException(\Akeneo\Pim\ApiClient\Exception\UnprocessableEntityHttpException::class);
+        $this->expectExceptionMessage('The value black_sneakers is already set on another product for the unique attribute sku');
+        
         $api = $this->createClient()->getProductApi();
         $api->create('black_sneakers', $this->newProduct());
     }

tests/Api/GetProductTest.php

@@ -27,10 +27,6 @@ public function test_get_product()
         Assert::assertEquals($product, json_decode($this->getProduct(), true));
     }
 
-    /**
-     * @expectedException \Akeneo\Pim\ApiClient\Exception\NotFoundHttpException
-     * @expectedExceptionMessage Resource `black_sneakers` does not exist.
-     */
     public function test_get_unknow_product()
     {
         $this->server->setResponseOfPath(
@@ -40,6 +36,9 @@ public function test_get_unknow_product()
             )
         );
 
+        $this->expectException(\Akeneo\Pim\ApiClient\Exception\NotFoundHttpException::class);
+        $this->expectExceptionMessage('Resource `black_sneakers` does not exist.');
+
         $api = $this->createClient()->getProductApi();
         $api->get('black_sneakers');
     }

tests/Api/UpsertListProductTest.php

@@ -12,7 +12,7 @@
 
 class UpsertListProductTest extends ApiTestCase
 {
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->server->setResponseOfPath(