MET-23: fix specs

Author: SamirBoulil

spec/AkeneoPimClientSpec.php

@@ -15,6 +15,7 @@
 use Akeneo\Pim\ApiClient\Api\FamilyVariantApiInterface;
 use Akeneo\Pim\ApiClient\Api\LocaleApiInterface;
 use Akeneo\Pim\ApiClient\Api\MeasureFamilyApiInterface;
+use Akeneo\Pim\ApiClient\Api\MeasurementFamilyApiInterface;
 use Akeneo\Pim\ApiClient\Api\MediaFileApiInterface;
 use Akeneo\Pim\ApiClient\Api\ProductApiInterface;
 use Akeneo\Pim\ApiClient\Api\ProductModelApiInterface;
@@ -36,6 +37,7 @@ function let(
         ChannelApiInterface $channelApi,
         CurrencyApiInterface $currencyApi,
         MeasureFamilyApiInterface $measureFamilyApi,
+        MeasurementFamilyApiInterface $measurementFamilyApi,
         AssociationTypeApiInterface $associationTypeApi,
         FamilyVariantApiInterface $familyVariantApi,
         ProductModelApiInterface $productModelApi
@@ -52,6 +54,7 @@ function let(
             $channelApi,
             $currencyApi,
             $measureFamilyApi,
+            $measurementFamilyApi,
             $associationTypeApi,
             $familyVariantApi,
             $productModelApi

spec/Api/MeasurementFamilyApiSpec.php

@@ -16,101 +16,39 @@
 
 class MeasurementFamilyApiSpec extends ObjectBehavior
 {
-    function let(
-        ResourceClientInterface $resourceClient,
-        PageFactoryInterface $pageFactory,
-        ResourceCursorFactoryInterface $cursorFactory
-    ) {
-        $this->beConstructedWith($resourceClient, $pageFactory, $cursorFactory);
+    function let(ResourceClientInterface $resourceClient) {
+        $this->beConstructedWith($resourceClient);
     }
 
     function it_is_initializable()
     {
         $this->shouldHaveType(MeasurementFamilyApi::class);
         $this->shouldImplement(MeasurementFamilyApiInterface::class);
-        $this->shouldImplement(ListableResourceInterface::class);
-        $this->shouldImplement(UpsertableResourceListInterface::class);
     }
 
-    function it_returns_a_list_of_measure_families_with_default_parameters(
-        $resourceClient,
-        $pageFactory,
-        PageInterface $page
-    ) {
-        $resourceClient
-            ->getResources(MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI, [], 100, false, [])
-            ->willReturn([]);
-
-        $pageFactory->createPage([])->willReturn($page);
-
-        $this->listPerPage()->shouldReturn($page);
-    }
-
-    function it_returns_a_list_of_measure_families_with_limit_and_count(
-        $resourceClient,
-        $pageFactory,
-        PageInterface $page
-    ) {
-        $resourceClient
-            ->getResources(MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI, [], 100, true, [])
-            ->willReturn([]);
-
-        $pageFactory->createPage([])->willReturn($page);
-
-        $this->listPerPage(100, true)->shouldReturn($page);
-    }
-
-    function it_returns_a_cursor_on_the_list_of_measure_families(
-        $resourceClient,
-        $pageFactory,
-        $cursorFactory,
-        PageInterface $page,
-        ResourceCursorInterface $cursor
-    ) {
-        $resourceClient
-            ->getResources(MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI, [], 100, false, [])
-            ->willReturn([]);
-
-        $pageFactory->createPage([])->willReturn($page);
-
-        $cursorFactory->createCursor(100, $page)->willReturn($cursor);
-
-        $this->all(100, [])->shouldReturn($cursor);
+    function it_returns_all_measurement_families($resourceClient) {
+        $resourceClient->getResource(MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI)->willReturn([]);
+        $this->all()->shouldReturn([]);
     }
 
-    function it_returns_a_list_of_measure_families_with_additional_query_parameters(
-        $resourceClient,
-        $pageFactory,
-        PageInterface $page
-    ) {
-        $resourceClient
-            ->getResources(MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI, [], 100, false, ['foo' => 'bar'])
-            ->willReturn([]);
-
-        $pageFactory->createPage([])->willReturn($page);
-
-        $this->listPerPage(100, false, ['foo' => 'bar'])->shouldReturn($page);
-    }
-
-    function it_upserts_a_list_of_measurement_families($resourceClient, UpsertResourceListResponse $response)
+    function it_upserts_a_list_of_measurement_families($resourceClient)
     {
-        $resourceClient
-            ->upsertStreamResourceList(
-              MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI,
-                [],
-                [
-                    ['code' => 'measurement_family_1'],
-                    ['code' => 'measurement_family_2'],
-                    ['code' => 'measurement_family_3'],
-                ]
-            )
-            ->willReturn($response);
+        $resourceClient->upsertJsonResourceList(
+            MeasurementFamilyApi::MEASUREMENT_FAMILIES_URI,
+            [],
+            [
+                ['code' => 'measurement_family_1'],
+                ['code' => 'measurement_family_2'],
+                ['code' => 'measurement_family_3'],
+            ]
+        )->willReturn([]);
 
-        $this
-            ->upsertList([
+        $this->upsertList(
+            [
                 ['code' => 'measurement_family_1'],
                 ['code' => 'measurement_family_2'],
                 ['code' => 'measurement_family_3'],
-            ])->shouldReturn($response);
+            ]
+        )->shouldReturn([]);
     }
 }