Remove several upsert which are useless

NolwennP · NolwennP · commit 82746cb6b73c · 2019-02-04T15:44:02.000+01:00
diff --git a/content/rest-api/resources.md b/content/rest-api/resources.md
@@ -1220,6 +1220,11 @@ Format for the `reference entity single link` and `reference entity multiple lin
 }
 ```
 
+::: warning
+You can have at max 100 attributes to describe the structure of one given reference entity.    
+As a consequence, when you ask for the list of attributes of one given reference entity, you'll see that the response is not paginated. It won't cause any performance issue, since you can't have more than 100 attributes per reference entity.
+:::
+
 ::: panel-link Want more details about the reference entity attribute resource? [Check its endpoints here!](/api-reference.html#Referenceentityattribute)
 :::
 
@@ -1260,6 +1265,11 @@ Below is the JSON format representing these reference entity attribute options.
 }
 ```
 
+::: warning
+You can have at max 100 options per attribute. If you want to have more, it makes totally sense to create a new reference entity that you can then use as an attribute.  
+As a consequence of this limit, when you ask for the list of attribute options of one given attribute, you'll see that the response is not paginated. It won't cause any performance issue, since you can't have more than 100 options per attribute.
+:::
+
 ::: panel-link Want more details about the reference entity attribute option resource? [Check its endpoints here!](/api-reference.html#Referenceentityattributeoption)
 :::
 
diff --git a/content/swagger/definitions.yaml b/content/swagger/definitions.yaml
@@ -57,10 +57,9 @@ ReferenceEntityAttributeList:
 ReferenceEntityAttributeOption:
   $ref: ./resources/reference_entity_attributes/definitions/reference_entity_attribute_option.yaml
 ReferenceEntityAttributeOptionList:
-  type: object
-  allOf:
-    - $ref:  '#/definitions/ItemList'
-    - $ref: ./resources/reference_entity_attributes/definitions/reference_entity_attribute_option.yaml
+  type: array
+  items:
+    $ref: ./resources/reference_entity_attributes/definitions/reference_entity_attribute_option.yaml
 
 ReferenceEntityRecord:
   type: object
diff --git a/content/swagger/resources/reference_entity_attributes/definitions/reference_entity_attribute_options.yaml b/content/swagger/resources/reference_entity_attributes/definitions/reference_entity_attribute_options.yaml
diff --git a/content/swagger/resources/reference_entity_attributes/definitions/reference_entity_attributes.yaml b/content/swagger/resources/reference_entity_attributes/definitions/reference_entity_attributes.yaml
diff --git a/content/swagger/resources/reference_entity_attributes/routes/reference_entity_attributes.yaml b/content/swagger/resources/reference_entity_attributes/routes/reference_entity_attributes.yaml
@@ -17,11 +17,6 @@ get:
         $ref: '#/definitions/ReferenceEntityAttributeList'
       x-examples: [
         {
-          "_links": {
-            "self": {
-              "href": "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/description"
-            }
-          },
           "code": "description",
           "labels": {
             "en_US": "Description",
@@ -38,11 +33,6 @@ get:
           "validation_regexp": null
         },
         {
-          "_links": {
-            "self": {
-              "href": "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/country"
-            }
-          },
           "code": "country",
           "labels": {
             "en_US": "Country",
@@ -54,11 +44,6 @@ get:
           "is_required_for_completeness": false
         },
         {
-          "_links": {
-            "self": {
-              "href": "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/collection_overview"
-            }
-          },
           "code": "collection_overview",
           "labels": {
             "en_US": "Collection overview",
@@ -76,47 +61,3 @@ get:
       $ref: "#/responses/401Error"
     406:
       $ref: "#/responses/406Error"
-patch:
-  summary: Update/create several attributes of a given reference entity
-  operationId: "patch_reference_entity_attributes"
-  tags:
-    - Reference entity attribute
-  x-versions:
-    - "3.0"
-  x-ee: true
-  description: This endpoint allows you to update and/or create several reference entity attributes at once. Note that if the attribute does not already exist for the given reference entity, it creates it.
-  parameters:
-    - $ref: '#/parameters/reference_entity_code'
-    - name: body
-      in: body
-      required: true
-      schema:
-        $ref: ../definitions/reference_entity_attributes.yaml
-  responses:
-    200:
-      description: OK
-      x-details: Returns an JSON array in which each object gives you the status of each attribute creation or update
-      x-no-entity: true
-      schema:
-        $ref: '#/definitions/ErrorByObject'
-      x-examples: [
-        {
-          "code": "description",
-          "status_code": 204
-        },
-        {
-          "code": "country",
-          "status_code": 422,
-          "message": "Property 'group' does not exist."
-        },
-        {
-          "code": "collection_overview",
-          "status_code": 201
-        }
-      ]
-    401:
-      $ref: "#/responses/401Error"
-    413:
-      $ref: "#/responses/413Error"
-    415:
-      $ref: "#/responses/415ErrorStream"
diff --git a/content/swagger/resources/reference_entity_attributes/routes/reference_entity_attributes_code_options.yaml b/content/swagger/resources/reference_entity_attributes/routes/reference_entity_attributes_code_options.yaml
@@ -10,124 +10,36 @@ get:
   parameters:
     - $ref: '#/parameters/reference_entity_code'
     - $ref: '#/parameters/attribute_code'
-    - $ref: '#/parameters/search_after'
   responses:
     200:
-      description: Return reference entity attribute options paginated
-      schema:
-        title: Entity Reference Attribute Options
-        type: object
-        allOf:
-          - $ref: '#/definitions/SearchAfterPagination'
-          - properties:
-              _embedded:
-                type: object
-                properties:
-                  _items:
-                    type: array
-                    items:
-                      $ref: '#/definitions/ReferenceEntityAttributeOptionList'
-      examples: {
-        _links: {
-          self: {
-            href: "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/trends/options"
-          },
-          first: {
-            href: "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/trends/options"
-          },
-          next: {
-            href: "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/trends/options?search_after=4x088w%5D%5D"
-          }
-        },
-        _embedded: {
-          _items: [
-            {
-              "_links": {
-                "self": {
-                  "href": "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/trends/options/woodland_retreat"
-                }
-              },
-              "code": "woodland_retreat",
-              "labels": {
-                "en_US": "Woodland Retreat",
-                "fr_FR": "Retraite dans les Bois"
-              }
-            },
-            {
-              "_links": {
-                "self": {
-                  "href": "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/trends/options/new_nordic"
-                }
-              },
-              "code": "new_nordic",
-              "labels": {
-                "en_US": "New Nordic",
-                "fr_FR": "Renouveau Scandinave"
-              }
-            },
-            {
-              "_links": {
-                "self": {
-                  "href": "https://demo.akeneo.com/api/rest/v1/reference-entities/brands/attributes/trends/options/global_nomad"
-                }
-              },
-              "code": "global_nomad",
-              "labels": {
-                "en_US": "Global Nomad",
-                "fr_FR": "Nomade du Monde"
-              }
-            }
-          ]
-        }
-      }
-    401:
-      $ref: "#/responses/401Error"
-    406:
-      $ref: "#/responses/406Error"
-patch:
-  summary: Update/create several reference entity attribute options
-  operationId: "patch_reference_entity_attributes__attribute_code__options"
-  tags:
-    - Reference entity attribute option
-  x-versions:
-    - "3.0"
-  x-ee: true
-  description: This endpoint allows you to update several options for a given attribute and a given reference entity at once.
-  x-body-by-line: Contains several lines, each line is a reference entity attribute option in JSON standard format
-  parameters:
-    - $ref: '#/parameters/reference_entity_code'
-    - $ref: '#/parameters/attribute_code'
-    - name: body
-      in: body
-      schema:
-        $ref: ../definitions/reference_entity_attribute_options.yaml
-  responses:
-    200:
-      description: OK
-      x-details: Returns an JSON array in which each object gives you the status of each reference entity attribute option creation or update
+      description: Return the options of the given attributes of the given reference entity
       x-no-entity: true
       schema:
-        $ref: '#/definitions/ErrorByObject'
+        $ref: '#/definitions/ReferenceEntityAttributeOptionList'
       x-examples: [
         {
           "code": "woodland_retreat",
-          "status_code": 204
+          "labels": {
+            "en_US": "Woodland Retreat",
+            "fr_FR": "Retraite dans les Bois"
+          }
         },
         {
           "code": "new_nordic",
-          "status_code": 422,
-          "message": "Property 'group' does not exist."
+          "labels": {
+            "en_US": "New Nordic",
+            "fr_FR": "Renouveau Scandinave"
+          }
         },
         {
           "code": "global_nomad",
-          "status_code": 201
+          "labels": {
+            "en_US": "Global Nomad",
+            "fr_FR": "Nomade du Monde"
+          }
         }
       ]
     401:
       $ref: "#/responses/401Error"
-    403:
-      $ref: "#/responses/403Error"
-    413:
-      $ref: "#/responses/413Error"
-    415:
-      $ref: "#/responses/415ErrorStream"
+    406:
+      $ref: "#/responses/406Error"
