Skip to content

Commit f5170f3

Browse files
committed
improved implementation of Configurer.uninstallAllEclipseVersionsUpToDate
1 parent b15be27 commit f5170f3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

libs/unpuzzle-plugin/src/main/groovy/org/akhikhl/unpuzzle/Configurer.groovy

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,14 @@ class Configurer {
194194
if(effectiveConfig.dryRun)
195195
return false
196196
def mavenDeployer = new Deployer(effectiveConfig.localMavenRepositoryDir)
197-
effectiveConfig.versionConfigs.each { eclipseVersion, vconf ->
197+
def result = !effectiveConfig.versionConfigs.find { eclipseVersion, vconf ->
198198
def eclipseDeployer = new EclipseDeployer(effectiveConfig.unpuzzleDir, vconf.eclipseMavenGroup, mavenDeployer)
199-
eclipseDeployer.allDownloadedPackagesAreUninstalled(vconf.sources)
199+
def uninstalled = eclipseDeployer.allDownloadedPackagesAreUninstalled(vconf.sources)
200+
log.debug '{} uninstalled: {}', eclipseVersion, uninstalled
201+
return !uninstalled
200202
}
203+
log.debug 'uninstallAllEclipseVersionsUpToDate: {}', result
204+
return result
201205
}
202206

203207
void uninstallEclipse() {

0 commit comments

Comments
 (0)