fix(video): do not treat unknown FFmpeg version as not installed

ref #1194

Author: akiver

src/node/video/ffmpeg/get-ffmpeg-version-from-executable.ts

@@ -1,7 +1,9 @@
 import { exec } from 'node:child_process';
 import { InvalidFfmpegExecutable } from 'csdm/node/video/errors/invalid-ffmpeg-executable';
 
-export async function getFfmpegVersionFromExecutable(executablePath: string): Promise<string | undefined> {
+export type FfmpegVersion = (string & {}) | '?';
+
+export async function getFfmpegVersionFromExecutable(executablePath: string): Promise<FfmpegVersion> {
   return new Promise((resolve, reject) => {
     exec(`"${executablePath}" -version`, { windowsHide: true }, (error, stdout) => {
       if (error !== null) {
@@ -24,7 +26,7 @@ export async function getFfmpegVersionFromExecutable(executablePath: string): Pr
 
       logger.warn(`Can't find FFmpeg version from stdout:`);
       logger.log(stdout);
-      return reject(new InvalidFfmpegExecutable());
+      return resolve('?');
     });
   });
 }

src/node/video/ffmpeg/get-installed-ffmpeg-version.ts

@@ -1,9 +1,9 @@
 import fs from 'fs-extra';
 import { InvalidFfmpegExecutable } from 'csdm/node/video/errors/invalid-ffmpeg-executable';
 import { getFfmpegExecutablePath } from './ffmpeg-location';
-import { getFfmpegVersionFromExecutable } from './get-ffmpeg-version-from-executable';
+import { getFfmpegVersionFromExecutable, type FfmpegVersion } from './get-ffmpeg-version-from-executable';
 
-export async function getInstalledFfmpegVersion(): Promise<string | undefined> {
+export async function getInstalledFfmpegVersion(): Promise<FfmpegVersion | undefined> {
   const ffmpegExecutablePath = await getFfmpegExecutablePath();
   const ffmpegExecutableExists = await fs.pathExists(ffmpegExecutablePath);
   if (!ffmpegExecutableExists) {

src/node/video/ffmpeg/is-ffmpeg-update-available.ts

@@ -3,7 +3,7 @@ import { getInstalledFfmpegVersion } from 'csdm/node/video/ffmpeg/get-installed-
 
 export async function isFfmpegUpdateAvailable(): Promise<boolean> {
   const installedVersion = await getInstalledFfmpegVersion();
-  if (installedVersion === undefined) {
+  if (installedVersion === undefined || installedVersion === '?') {
     return false;
   }
 

src/server/handlers/renderer-process/settings/disable-ffmpeg-custom-location-handler.ts

@@ -11,7 +11,7 @@ import type { FfmpegVersionChangedPayload } from './ffmpeg-version-changed-paylo
 export async function disableFfmpegCustomLocationHandler(clearCustomLocation?: boolean) {
   const payload: FfmpegVersionChangedPayload = {
     errorCode: undefined,
-    version: undefined,
+    version: '?',
     isUpdateAvailable: false,
   };
 
@@ -38,7 +38,7 @@ export async function disableFfmpegCustomLocationHandler(clearCustomLocation?: b
 
     const version = await getFfmpegVersionFromExecutable(defaultFfmpegExecutablePath);
     let isUpdateAvailable = false;
-    if (version !== undefined) {
+    if (version !== '?') {
       isUpdateAvailable = await checkForFfmpegUpdate(version);
     }
 

src/server/handlers/renderer-process/settings/enable-ffmpeg-custom-location-handler.ts

@@ -5,6 +5,7 @@ import { FileNotFound } from 'csdm/node/filesystem/errors/file-not-found';
 import type { FfmpegSettings } from 'csdm/node/settings/settings';
 import type { FfmpegVersionChangedPayload } from './ffmpeg-version-changed-payload';
 import { handleError } from '../../handle-error';
+import { InvalidFfmpegExecutable } from 'csdm/node/video/errors/invalid-ffmpeg-executable';
 
 export async function enableFfmpegCustomLocationHandler(customExecutablePath: string) {
   try {
@@ -14,6 +15,9 @@ export async function enableFfmpegCustomLocationHandler(customExecutablePath: st
     }
 
     const version = await getFfmpegVersionFromExecutable(customExecutablePath);
+    if (version === '?') {
+      throw new InvalidFfmpegExecutable();
+    }
 
     const ffmpegSettings: Partial<FfmpegSettings> = {
       customLocationEnabled: true,

src/server/handlers/renderer-process/settings/ffmpeg-version-changed-payload.ts

@@ -1,7 +1,8 @@
 import type { ErrorCode } from 'csdm/common/error-code';
+import type { FfmpegVersion } from 'csdm/node/video/ffmpeg/get-ffmpeg-version-from-executable';
 
 export type FfmpegVersionChangedPayload = {
   errorCode: ErrorCode | undefined;
-  version: string | undefined;
+  version: FfmpegVersion;
   isUpdateAvailable: boolean;
 };

src/ui/match/video/ffmpeg/ffmpeg-reducer.ts

@@ -2,10 +2,11 @@ import { createReducer } from '@reduxjs/toolkit';
 import { initializeVideoSuccess } from 'csdm/ui/match/video/video-actions';
 import { ffmpegVersionChanged } from 'csdm/ui/settings/settings-actions';
 import { installFfmpegSuccess, updateFfmpegSuccess } from './ffmpeg-actions';
+import type { FfmpegVersion } from 'csdm/node/video/ffmpeg/get-ffmpeg-version-from-executable';
 
 export type FfmpegState = {
   isUpdateAvailable: boolean;
-  version: string | undefined;
+  version: FfmpegVersion | undefined;
 };
 
 const initialState: FfmpegState = {

src/ui/match/video/ffmpeg/use-installed-ffmpeg-version.ts

@@ -1,6 +1,6 @@
 import { useFfmpegState } from './use-ffmpeg-state';
 
-export function useInstalledFfmpegVersion(): string | undefined {
+export function useInstalledFfmpegVersion() {
   const ffmpegState = useFfmpegState();
 
   return ffmpegState.version;