Release 1.4.11 (#120)

* Resolved Akka.Remote LogSource race condition (#118)

* Recreating Akka.Remote LogSource race condition

added reproduction for akkadotnet/akka.net#4579

* close #4579

for Serliog only - need to make a similar change for NLog

* minor fixup

* Bump AkkaVersion from 1.4.10 to 1.4.11 (#119)

Bumps `AkkaVersion` from 1.4.10 to 1.4.11.

Updates `Akka` from 1.4.10 to 1.4.11
- [Release notes](https://github.com/akkadotnet/akka.net/releases)
- [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md)
- [Commits](akkadotnet/akka.net@1.4.10...1.4.11)

Updates `Akka.TestKit.Xunit2` from 1.4.10 to 1.4.11
- [Release notes](https://github.com/akkadotnet/akka.net/releases)
- [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md)
- [Commits](akkadotnet/akka.net@1.4.10...1.4.11)

Updates `Akka.Cluster` from 1.4.10 to 1.4.11
- [Release notes](https://github.com/akkadotnet/akka.net/releases)
- [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md)
- [Commits](akkadotnet/akka.net@1.4.10...1.4.11)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Update Release Notes for Release 1.4.11

Co-authored-by: Aaron Stannard <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Author: 3 people

RELEASE_NOTES.md

@@ -1,3 +1,8 @@
+#### 1.4.11 November 7 2020 ####
+
+* Updated to [Akka.NET v1.4.11](https://github.com/akkadotnet/akka.net/releases/tag/1.4.11)
+* Resolved a Akka.Remote LogSource race condition
+
 #### 1.4.10 October 28 2020 ####
 
 * Updated to [Akka.NET v1.4.10](https://github.com/akkadotnet/akka.net/releases/tag/1.4.10)

src/Akka.Logger.Serilog.Tests/Akka.Logger.Serilog.Tests.csproj

@@ -10,6 +10,7 @@
     <PackageReference Include="xunit.runner.visualstudio" Version="$(XunitVersion)" />
     <PackageReference Include="xunit" Version="$(XunitVersion)" />
     <PackageReference Include="Akka.TestKit.Xunit2" Version="$(AkkaVersion)" />
+    <PackageReference Include="Akka.Cluster" Version="$(AkkaVersion)" />
     <PackageReference Include="FluentAssertions" Version="5.10.3" />
     <PackageReference Include="Serilog.Sinks.ColoredConsole" Version="3.0.1" />
   </ItemGroup>

src/Akka.Logger.Serilog.Tests/Bugfix4579Spec.cs

@@ -0,0 +1,73 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Akka.Actor;
+using Akka.Cluster;
+using Akka.Configuration;
+using Akka.Event;
+using FluentAssertions;
+using Serilog;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace Akka.Logger.Serilog.Tests
+{
+    public class Bugfix4579Spec : TestKit.Xunit2.TestKit
+    {
+        public Bugfix4579Spec(ITestOutputHelper output) : base(GetConfig(), output: output)
+        {
+            global::Serilog.Log.Logger = new LoggerConfiguration()
+                .WriteTo.Sink(_sink)
+                .MinimumLevel.Information()
+                .CreateLogger();
+
+            var logSource = Sys.Name;
+            var logClass = typeof(ActorSystem);
+
+        }
+
+        private readonly TestSink _sink = new TestSink();
+
+        public static Config GetConfig()
+        {
+            return @"akka.actor.provider = cluster
+                    akka.remote.dot-netty.tcp.hostname = localhost
+                    akka.remote.dot-netty.tcp.port = 5110
+                    akka.cluster.seed-nodes = [""akka.tcp://test@localhost:5110""]
+                    akka.loglevel = DEBUG
+                    akka.loggers=[""Akka.Logger.Serilog.SerilogLogger, Akka.Logger.Serilog""]";
+        }
+
+        private class LoggerActor : UntypedActor
+        {
+            private readonly ILoggingAdapter _logger = Context.GetLogger<SerilogLoggingAdapter>(); // correct
+
+            protected override void OnReceive(object message)
+            {
+                _logger.ForContext("semantic", true);
+                _logger.Info("My boss makes me use {msg} logging", message);
+            }
+        }
+
+        /// <summary>
+        /// Reproduction of https://github.com/akkadotnet/akka.net/issues/4579
+        /// </summary>
+        [Fact]
+        public async Task SerilogShouldNotCrashWhileAkkaRemoteIsBound()
+        {
+            var upProbe = CreateTestProbe();
+            var semanticLogger = Sys.ActorOf(Props.Create(() => new LoggerActor()));
+            Sys.EventStream.Subscribe(TestActor, typeof(Info));
+            Cluster.Cluster.Get(Sys).Subscribe(upProbe, ClusterEvent.SubscriptionInitialStateMode.InitialStateAsEvents, typeof(ClusterEvent.MemberUp));
+            upProbe.FishForMessage(f => f is ClusterEvent.MemberUp);
+            Sys.Log.Info("Foo");
+            Sys.Log.Info("Foo");
+            semanticLogger.Tell("hit");
+            semanticLogger.Tell("hit");
+            var logs = ReceiveN(4); // receive all 4 logs
+        }
+
+    }
+}

src/Akka.Logger.Serilog/SerilogLogger.cs

@@ -23,12 +23,11 @@ namespace Akka.Logger.Serilog
     /// </summary>
     public class SerilogLogger : ReceiveActor, IRequiresMessageQueue<ILoggerMessageQueueSemantics>
     {
-        private readonly ILoggingAdapter _log = Context.GetLogger();
+        private readonly ILoggingAdapter _log = Logging.GetLogger(Context.System.EventStream, "SerilogLogger");
 
         private static string GetFormat(object message)
         {
-            var logMessage = message as LogMessage;
-            return logMessage != null ? logMessage.Format : "{Message:l}";
+            return message is LogMessage logMessage ? logMessage.Format : "{Message:l}";
         }
 
         private static object[] GetArgs(object message)

src/common.props

@@ -14,7 +14,7 @@
     <XunitVersion>2.4.1</XunitVersion>
     <TestSdkVersion>16.7.1</TestSdkVersion>
     <NBenchVersion>2.0.1</NBenchVersion>
-    <AkkaVersion>1.4.10</AkkaVersion>
+    <AkkaVersion>1.4.11</AkkaVersion>
     <NetCoreTestVersion>netcoreapp3.1</NetCoreTestVersion>
     <NetFrameworkTestVersion>net461</NetFrameworkTestVersion>
     <NetStandardLibVersion>netstandard2.0</NetStandardLibVersion>