Replace build system (#288)

* removed unused junk

* added updated scripts

* simplify `dotnet` commands

* added coverlet settings

* fixed test execution errors

* added coverlet

* simplify

* fix release pipeline

Author: Aaronontheweb

.github/dependabot.yml

@@ -1,23 +1,17 @@
 version: 2
 updates:
-- package-ecosystem: nuget
+- package-ecosystem: github-actions
   directory: "/"
   schedule:
     interval: daily
-  open-pull-requests-limit: 10
-  ignore:
-  - dependency-name: Akka.Cluster.TestKit
-    versions:
-    - 1.4.16
-    - 1.4.17
-    - 1.4.18
-  - dependency-name: Akka.TestKit.Xunit2
-    versions:
-    - 1.4.16
-    - 1.4.17
-    - 1.4.18
-  - dependency-name: Akka.Remote.TestKit
-    versions:
-    - 1.4.16
-    - 1.4.17
-    - 1.4.18
+
+- package-ecosystem: "dotnet-sdk"
+  directory: "/"
+  schedule:
+    interval: "weekly"
+    day: "wednesday"
+
+- package-ecosystem: nuget
+  directory: "/"
+  schedule:
+    interval: daily

Akka.MultiNodeTestRunner.sln

@@ -5,14 +5,13 @@ VisualStudioVersion = 16.0.29230.47
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{79D71264-186B-4F62-8930-35DD9ECCAF3B}"
 	ProjectSection(SolutionItems) = preProject
-		build.cmd = build.cmd
-		build.fsx = build.fsx
 		build.ps1 = build.ps1
-		build.sh = build.sh
 		README.md = README.md
 		RELEASE_NOTES.md = RELEASE_NOTES.md
-		src\Directory.Build.props = src\Directory.Build.props
-		src\Directory.Packages.props = src\Directory.Packages.props
+		coverlet.runsettings = coverlet.runsettings
+		Directory.Build.props = Directory.Build.props
+		Directory.Packages.props = Directory.Packages.props
+		global.json = global.json
 	EndProjectSection
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.MultiNode.TestAdapter", "src\Akka.MultiNode.TestAdapter\Akka.MultiNode.TestAdapter.csproj", "{F3037C62-E780-4619-89B3-BA21C7168DFA}"
@@ -23,14 +22,6 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.MultiNode.TestAdapter.
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.MultiNode.RemoteHost", "src\Akka.MultiNode.RemoteHost\Akka.MultiNode.RemoteHost.csproj", "{D59D10BA-E776-4AC6-B8F0-BAB40544439C}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build-system", "build-system", "{C7DE41DA-ADDE-498E-95DB-D760C32D3C6B}"
-	ProjectSection(SolutionItems) = preProject
-		build-system\azure-pipeline.template.yaml = build-system\azure-pipeline.template.yaml
-		build-system\pr-validation.yaml = build-system\pr-validation.yaml
-		build-system\README.md = build-system\README.md
-		build-system\windows-release.yaml = build-system\windows-release.yaml
-	EndProjectSection
-EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -61,6 +52,5 @@ Global
 		SolutionGuid = {B99E6BB8-642A-4A68-86DF-69567CBA700A}
 	EndGlobalSection
 	GlobalSection(NestedProjects) = preSolution
-		{C7DE41DA-ADDE-498E-95DB-D760C32D3C6B} = {79D71264-186B-4F62-8930-35DD9ECCAF3B}
 	EndGlobalSection
 EndGlobal

CODE_OF_CONDUCT.md

@@ -1,14 +1,13 @@
 <Project>
   <PropertyGroup>
-    <Copyright>Copyright © 2013-2023 Akka.NET Team</Copyright>
+    <Copyright>Copyright © 2013-$([System.DateTime]::Now.Year) Akka.NET Team</Copyright>
     <Authors>Akka.NET Team</Authors>
-    <VersionPrefix>1.5.8</VersionPrefix>
+    <VersionPrefix>1.5.28</VersionPrefix>
     <NoWarn>$(NoWarn);CS1591;xUnit1013</NoWarn>
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
   <PropertyGroup>
-    <NetCoreTestVersion>netcoreapp3.1</NetCoreTestVersion>
-    <NetTestVersion>net6.0</NetTestVersion>
+    <NetTestVersion>net9.0</NetTestVersion>
     <NetStandardLibVersion>netstandard2.0</NetStandardLibVersion>
   </PropertyGroup>
   <PropertyGroup>
@@ -20,16 +19,18 @@
   </ItemGroup>
   <!-- Embedded icon and readme file -->
   <ItemGroup>
-    <None Include="$(MSBuildThisFileDirectory)\..\docs\images\icon.png" Pack="true" PackagePath="\" />
-    <None Include="$(MSBuildThisFileDirectory)\..\README.md" Pack="true" PackagePath="\" />
+    <None Include="$(MSBuildThisFileDirectory)\akkalogo.png" Pack="true" PackagePath="\" />
+    <None Include="$(MSBuildThisFileDirectory)\README.md" Pack="true" PackagePath="\" />
   </ItemGroup>
   <!-- NuGet .nupkg options -->
   <PropertyGroup>
-    <PackageReleaseNotes>[Updated Akka.NET to 1.5.8](https://github.com/akkadotnet/akka.net/releases/tag/1.5.8) - which resolves issues with Akka.NET runtime and `Polyfill` errors.</PackageReleaseNotes>
+    <PackageReleaseNotes>1.5.25 June 17 2024
+
+* [Updated Akka.NET to 1.5.25](https://github.com/akkadotnet/akka.net/releases/tag/1.5.25)</PackageReleaseNotes>
     <PackageTags>akka;actors;actor model;Akka;concurrency;test</PackageTags>
     <PackageProjectUrl>https://github.com/akkadotnet/Akka.MultiNodeTestRunner</PackageProjectUrl>
     <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
-    <PackageIcon>icon.png</PackageIcon>
+    <PackageIcon>akkalogo.png</PackageIcon>
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <!-- Optional: Embed source files that are not tracked by the source control manager in the PDB -->

src/Directory.Build.props Directory.Build.propssrc/Directory.Build.props renamed to Directory.Build.props

@@ -6,10 +6,12 @@
   <!-- App dependencies -->
   <ItemGroup>
     <PackageVersion Include="Akka.Cluster.TestKit" Version="1.5.39" />
+    <PackageVersion Include="coverlet.collector" Version="6.0.4" />
     <PackageVersion Include="TeamCity.ServiceMessages" Version="4.1.1" />
     <PackageVersion Include="System.CodeDom" Version="9.0.4" />
     <PackageVersion Include="System.Runtime.Loader" Version="4.3.0" />
     <PackageVersion Include="xunit.runner.utility" Version="2.8.1" />
+    <PackageVersion Include="xunit.runner.visualstudio" Version="3.0.2" />
   </ItemGroup>
   <!-- Test dependencies -->
   <ItemGroup>

src/Directory.Packages.props Directory.Packages.propssrc/Directory.Packages.props renamed to Directory.Packages.props

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <solution>
+    <add key="disableSourceControlIntegration" value="true" />
+  </solution>
+  <packageSources>
+    <clear />
+    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
+  </packageSources>
+</configuration>

NuGet.Config

@@ -2,64 +2,83 @@ parameters:
   name: ''
   displayName: ''
   vmImage: ''
-  scriptFileName: ''
-  scriptArgs: 'all'
+  outputDirectory: ''
+  artifactName: ''
   timeoutInMinutes: 120
 
 jobs:
   - job: ${{ parameters.name }}
     displayName: ${{ parameters.displayName }}
     timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
+
     pool:
       vmImage: ${{ parameters.vmImage }}
+
     steps:
-      - task: UseDotNet@2
-        displayName: 'Use .NET 8 SDK 8.0.x'
-        inputs:
-          version: 8.0.x
-      - task: UseDotNet@2
-        displayName: 'Use .NET Core Runtime 6.0.x'
-        inputs:
-          packageType: runtime
-          version: 6.0.x
       - checkout: self  # self represents the repo where the initial Pipelines YAML file was found
         clean: false  # whether to fetch clean each time
         submodules: recursive  # set to 'true' for a single level of submodules or 'recursive' to get submodules of submodules
         persistCredentials: true
-      # Linux or macOS
-      - task: Bash@3 
-        displayName: Linux / OSX Build
+
+      - task: UseDotNet@2
+        displayName: 'Use .NET'
         inputs:
-          filePath: ${{ parameters.scriptFileName }}
-          arguments: ${{ parameters.scriptArgs }}
-        continueOnError: true
-        condition: in( variables['Agent.OS'], 'Linux', 'Darwin' )
-      # Windows
-      - task: BatchScript@1
-        displayName: Windows Build
+          packageType: 'sdk'
+          useGlobalJson: true
+          
+      - pwsh: |
+          .\build.ps1
+        displayName: 'Update Release Notes'
+        continueOnError: false
+
+      - task: DotNetCoreCLI@2
+        displayName: Build
         inputs:
-          filename: ${{ parameters.scriptFileName }}
-          arguments: ${{ parameters.scriptArgs }}
-        continueOnError: true
-        condition: eq( variables['Agent.OS'], 'Windows_NT' )
+          command: 'build'
+          arguments: '-c Release'
+        continueOnError: false
+
+      - script: dotnet test -c Release --no-build --logger:trx --collect:"XPlat Code Coverage" --results-directory TestResults --settings coverlet.runsettings
+        displayName: 'Run tests'
+        continueOnError: true # Allow continuation even if tests fail
+
       - task: PublishTestResults@2
         inputs:
-          testRunner: VSTest
+          testResultsFormat: VSTest
           testResultsFiles: '**/*.trx' #TestResults folder usually
           testRunTitle: ${{ parameters.name }}
           mergeTestResults: true
-      - task: CopyFiles@2
-        displayName: 'Copy Build Output'
+          failTaskOnFailedTests: false
+          publishRunAttachments: true
+
+      - task: reportgenerator@5
+        displayName: ReportGenerator
+        condition: always() # Run this step regardless of previous step outcomes
+        continueOnError: true
         inputs:
-          sourceFolder: ${{ parameters.outputDirectory }}
-          contents: '**\*'
-          targetFolder: $(Build.ArtifactStagingDirectory)
-          continueOnError: boolean  # 'true' if future steps should run even if this step fails; defaults to 'false'
+          reports: '$(Build.SourcesDirectory)/TestResults/**/*.cobertura.xml'
+          targetdir: '$(Build.SourcesDirectory)/coveragereport'
+          reporttypes: 'HtmlInline_AzurePipelines;Cobertura;Badges'
+          assemblyfilters: '-xunit*'
+          publishCodeCoverageResults: true
+
+      - publish: $(Build.SourcesDirectory)/coveragereport
+        displayName: 'Publish Coverage Report'
+        condition: and(always(), eq(variables['Agent.OS'], 'Windows_NT'))
+        continueOnError: true
+        artifact: 'CoverageReports'
+          
+      - script: dotnet pack -c Release -o $(Build.ArtifactStagingDirectory)/nuget
+        displayName: 'Create packages'
+          
       - task: PublishBuildArtifacts@1
+        displayName: 'Publish artifacts'
         inputs:
-          pathtoPublish: '$(Build.ArtifactStagingDirectory)'
-          artifactName: ${{ parameters.artifactName }}
+          PathtoPublish: '$(Build.ArtifactStagingDirectory)/nuget'
+          ArtifactName: 'nuget'
+          publishLocation: 'Container'
+
       - script: 'echo 1>&2'
         failOnStderr: true
         displayName: 'If above is partially succeeded, then fail'
-        condition: eq(variables['Agent.JobStatus'], 'SucceededWithIssues')
+        condition: eq(variables['Agent.JobStatus'], 'SucceededWithIssues')

akkalogo.png

@@ -20,16 +20,13 @@ jobs:
       name: 'windows_pr'
       displayName: 'Windows PR Validation'
       vmImage: 'windows-latest'
-      scriptFileName: build.cmd
-      scriptArgs: all
       outputDirectory: 'bin/nuget'
       artifactName: 'nuget_pack-$(Build.BuildId)'
+
   - template: azure-pipeline.template.yaml
     parameters:
       name: 'linux_pr'
       displayName: 'Linux PR Validation'
       vmImage: 'ubuntu-latest'
-      scriptFileName: ./build.sh
-      scriptArgs: all
       outputDirectory: 'bin/nuget'
-      artifactName: 'nuget_pack-$(Build.BuildId)'
+      artifactName: 'nuget_pack-$(Build.BuildId)'