Fix Shard remember-entities flag mismatch causing entity restart failures (#8054)

The Shard constructor derived _rememberEntities from whether a provider
was passed, but passed settings.RememberEntities (from HOCON config) to
the Entities class. When a provider was supplied without the config flag,
the Entities._remembering set was never populated. This caused
OnUpdateDone to see no pending work and overwrite the
WaitingForRememberEntitiesStore behavior with Idle, dropping the
subsequent UpdateDone from the store and preventing entity restarts.

Author: Aaronontheweb

src/contrib/cluster/Akka.Cluster.Sharding/Shard.cs

@@ -1007,7 +1007,7 @@ public Shard(
             var failOnInvalidStateTransition =
                 Context.System.Settings.Config.GetBoolean(
                     "akka.cluster.sharding.fail-on-invalid-entity-state-transition");
-            _entities = new Entities(Log, settings.RememberEntities, _verboseDebug, failOnInvalidStateTransition);
+            _entities = new Entities(Log, _rememberEntities, _verboseDebug, failOnInvalidStateTransition);
 
             var idleInterval = TimeSpan.FromTicks(_settings.PassivateIdleEntityAfter.Ticks / 2);
             _passivateIdleTask = _settings.ShouldPassivateIdleEntities