Skip to content

Commit 2e64b9a

Browse files
lkpdnMikko Salomäki
authored andcommitted
virtio_net: ensure netdev_tx_reset_queue is called on tx ring resize
commit 1480f0f61b675567ca5d0943d6ef2e39172dcafd upstream. virtnet_tx_resize() flushes remaining tx skbs, requiring DQL counters to be reset when flushing has actually occurred. Add virtnet_sq_free_unused_buf_done() as a callback for virtqueue_reset() to handle this. Fixes: c8bd1f7 ("virtio_net: add support for Byte Queue Limits") Cc: <[email protected]> # v6.11+ Signed-off-by: Koichiro Den <[email protected]> Acked-by: Jason Wang <[email protected]> Reviewed-by: Xuan Zhuo <[email protected]> Signed-off-by: Paolo Abeni <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 2c0c4c2 commit 2e64b9a

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

drivers/net/virtio_net.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ struct virtio_net_common_hdr {
502502
};
503503

504504
static void virtnet_sq_free_unused_buf(struct virtqueue *vq, void *buf);
505+
static void virtnet_sq_free_unused_buf_done(struct virtqueue *vq);
505506
static int virtnet_xdp_handler(struct bpf_prog *xdp_prog, struct xdp_buff *xdp,
506507
struct net_device *dev,
507508
unsigned int *xdp_xmit,
@@ -3228,7 +3229,8 @@ static int virtnet_tx_resize(struct virtnet_info *vi, struct send_queue *sq,
32283229

32293230
virtnet_tx_pause(vi, sq);
32303231

3231-
err = virtqueue_resize(sq->vq, ring_num, virtnet_sq_free_unused_buf, NULL);
3232+
err = virtqueue_resize(sq->vq, ring_num, virtnet_sq_free_unused_buf,
3233+
virtnet_sq_free_unused_buf_done);
32323234
if (err)
32333235
netdev_err(vi->dev, "resize tx fail: tx queue index: %d err: %d\n", qindex, err);
32343236

@@ -5996,6 +5998,14 @@ static void virtnet_sq_free_unused_buf(struct virtqueue *vq, void *buf)
59965998
xdp_return_frame(ptr_to_xdp(buf));
59975999
}
59986000

6001+
static void virtnet_sq_free_unused_buf_done(struct virtqueue *vq)
6002+
{
6003+
struct virtnet_info *vi = vq->vdev->priv;
6004+
int i = vq2txq(vq);
6005+
6006+
netdev_tx_reset_queue(netdev_get_tx_queue(vi->dev, i));
6007+
}
6008+
59996009
static void free_unused_bufs(struct virtnet_info *vi)
60006010
{
60016011
void *buf;

0 commit comments

Comments
 (0)