Skip to content

Commit b412af5

Browse files
committed
Disabling PlugCowboy Plug.Router resolution until a better way can be found
1 parent a9d3bc3 commit b412af5

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

lib/prom_ex/plugins/plug_cowboy.ex

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,10 @@ if Code.ensure_loaded?(Plug.Cowboy) do
7070
"""
7171

7272
use PromEx.Plugin
73+
7374
require Logger
74-
alias Plug.Cowboy.Conn
75+
76+
# alias Plug.Cowboy.Conn
7577

7678
@default_route "Unknown"
7779

@@ -195,12 +197,14 @@ if Code.ensure_loaded?(Plug.Cowboy) do
195197
end
196198

197199
defp maybe_get_parametrized_path(req, routers) do
200+
# credo:disable-for-next-line
198201
cond do
199202
Code.ensure_loaded?(Phoenix) ->
200203
find_phoenix_route(routers, req)
201204

202-
Code.ensure_loaded?(Plug.Router) ->
203-
find_plug_route(routers, req)
205+
# TODO: This needs to be further investigated to see how the normalized route can be extracted
206+
# Code.ensure_loaded?(Plug.Router) ->
207+
# find_plug_route(routers, req)
204208

205209
true ->
206210
@default_route
@@ -220,17 +224,17 @@ if Code.ensure_loaded?(Plug.Cowboy) do
220224
end)
221225
end
222226

223-
defp find_plug_route(routers, req) do
224-
conn = Conn.conn(req)
225-
226-
routers
227-
|> Enum.find_value(@default_route, fn router ->
228-
case router.call(conn, []) do
229-
%{private: %{plug_route: {route, _fn}}} -> route
230-
_ -> false
231-
end
232-
end)
233-
end
227+
# defp find_plug_route(routers, req) do
228+
# conn = Conn.conn(req)
229+
#
230+
# routers
231+
# |> Enum.find_value(@default_route, fn router ->
232+
# case router.call(conn, []) do
233+
# %{private: %{plug_route: {route, _fn}}} -> route
234+
# _ -> false
235+
# end
236+
# end)
237+
# end
234238

235239
defp get_http_status(resp_status) when is_integer(resp_status) do
236240
to_string(resp_status)

0 commit comments

Comments
 (0)