Skip to content

Commit 14394cb

Browse files
scope parameter removed
1 parent aae7ece commit 14394cb

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

src/ApiBundle/Controller/AuthController.php

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ private function validateAdminUser(Request $request) {
223223
* {"name"="dob", "dataType"="datetime", "required"=true, "description"="date of birth mm/dd/yyyy"},
224224
* {"name"="email", "dataType"="email", "required"=true, "description"="Email"},
225225
* {"name"="email_confirmation", "dataType"="integer", "required"=true, "description"="0-email confirmation not required, 1-required"},
226-
* {"name"="scope", "dataType"="string", "required"=true, "description"="Fixed value - API"},
227226
* {"name"="_locale", "dataType"="string", "required"=false, "description"="User locale. Will default to en"}
228227
* },
229228
* )
@@ -239,7 +238,6 @@ public function postRegisterAction()
239238
$this->validateEmail($request);
240239
$this->validateFirstname($request);
241240
$this->validateDob($request);
242-
$this->validateScope($request);
243241

244242
$user = $userManager->createUser();
245243

@@ -249,7 +247,7 @@ public function postRegisterAction()
249247
$user->setFirstname($request->request->get('firstname'));
250248
$user->setLastname($request->request->get('lastname'));
251249
$user->setDob($request->request->get('dob'));
252-
$user->setRoles(array('ROLE_'. $request->request->get('scope')));
250+
$user->setRoles(array('ROLE_API'));
253251
$user->setEnabled(true);
254252

255253
$userManager->updateUser($user);
@@ -373,18 +371,6 @@ private function validateDob(Request $request) {
373371
}
374372
}
375373

376-
/**
377-
* Validate dob
378-
*/
379-
private function validateScope(Request $request) {
380-
$scope = $request->request->get('scope');
381-
382-
// Check if scope is set to API
383-
if ('API' != $scope) {
384-
$this->logAndThrowError(400, 'Invalid scope: '.$scope, $this->get('translator')->trans('api.show_error_scope', array(), 'messages', $request->getLocale()), $request->getLocale());
385-
}
386-
}
387-
388374
/**
389375
* Change Password request. Will return a JsonResponse(username, msg) upon success.
390376
*
@@ -710,7 +696,6 @@ protected function getObfuscatedEmail(UserInterface $user)
710696
* {"name"="client_secret", "dataType"="string", "required"=true, "description"="oAuth ClientSecret"},
711697
* {"name"="username", "dataType"="string", "required"=true, "description"="username"},
712698
* {"name"="password", "dataType"="string", "required"=true, "description"="password"},
713-
* {"name"="scope", "dataType"="string", "required"=true, "description"="Fixed value - API"},
714699
* {"name"="_locale", "dataType"="string", "required"=false, "description"="User locale. Will default to en"}
715700
* },
716701
* )
@@ -723,12 +708,11 @@ public function postAccessTokenAction()
723708

724709
$username = $data['username'];
725710
$password = $data['password'];
726-
$scope = $data['scope'];
727711
$clientId = $data['client_id'];
728712
$clientSecret = $data['client_secret'];
729713
$grantType = 'password';
730714

731-
if (!$username || !$password || !$clientId || !$clientSecret || !$scope) {
715+
if (!$username || !$password || !$clientId || !$clientSecret) {
732716
$this->logAndThrowError(400, 'Unable to obtain Access Token for missing username/password/clientId/clientSecret.', $this->get('translator')->trans('api.show_error_server_fault', array(), 'messages', $request->getLocale()), $request->getLocale());
733717
}
734718

@@ -802,7 +786,6 @@ private function fetchAccessToken(Request $request, $grantType)
802786
$refreshToken = array_key_exists('refresh_token', $data) ? $data['refresh_token'] : null;
803787
$username = array_key_exists('username', $data) ? $data['username'] : null;
804788
$password = array_key_exists('password', $data) ? $data['password'] : null;
805-
$scope = array_key_exists('scope', $data) ? $data['scope'] : null;
806789

807790
$client = new OAuth2\Client($clientId, $clientSecret);
808791

0 commit comments

Comments
 (0)