Release v0.12.1

Author: alajmo

Makefile

@@ -2,7 +2,7 @@ NAME    := sake
 PACKAGE := github.com/alajmo/$(NAME)
 DATE    := $(shell date +%FT%T%Z)
 GIT     := $(shell [ -d .git ] && git rev-parse --short HEAD)
-VERSION := v0.12.0
+VERSION := v0.12.1
 
 default: build
 

core/run/exec.go

@@ -393,7 +393,7 @@ func ParseServers(sshConfigFile *string, servers *[]dao.Server, runFlags *core.R
 
 				port := cfg[proxyJump].Port
 				if port != "" {
-					p, err := strconv.ParseInt(port, 10, 16)
+					p, err := strconv.ParseUint(port, 10, 16)
 					if err != nil {
 						errConnect := &ErrConnect{
 							Name:   (*servers)[i].Name,
@@ -441,7 +441,7 @@ func ParseServers(sshConfigFile *string, servers *[]dao.Server, runFlags *core.R
 
 			port := cfg[(*servers)[i].BastionHost].Port
 			if port != "" {
-				p, err := strconv.ParseInt(port, 10, 16)
+				p, err := strconv.ParseUint(port, 10, 16)
 				if err != nil {
 					errConnect := &ErrConnect{
 						Name:   (*servers)[i].Name,
@@ -486,7 +486,7 @@ func ParseServers(sshConfigFile *string, servers *[]dao.Server, runFlags *core.R
 		// Port
 		port := serv.Port
 		if port != "" {
-			p, err := strconv.ParseInt(port, 10, 16)
+			p, err := strconv.ParseUint(port, 10, 16)
 			if err != nil {
 				errConnect := &ErrConnect{
 					Name:   (*servers)[i].Name,

core/sake.1

@@ -1,4 +1,4 @@
-.TH "SAKE" "1" "2022-10-09T22:24:44CEST" "v0.12.0" "Sake Manual" "sake"
+.TH "SAKE" "1" "2022-10-16T08:03:53CEST" "v0.12.1" "Sake Manual" "sake"
 .SH NAME
 sake - sake is a command runner for local and remote hosts
 

core/utils.go

@@ -215,8 +215,9 @@ func ParseHostName(hostname string, defaultUser string, defaultPort uint16) (str
 	case 4:
 		if strings.Contains(host, ":") {
 			lastInd := strings.LastIndex(host, ":")
-			p, err := strconv.ParseInt(host[lastInd+1:], 0, 16)
+			p, err := strconv.ParseUint(host[lastInd+1:], 10, 16)
 			if err != nil {
+				fmt.Println(1111)
 				return "", "", 22, err
 			}
 			host = host[:lastInd]
@@ -228,7 +229,7 @@ func ParseHostName(hostname string, defaultUser string, defaultPort uint16) (str
 	case 6:
 		if strings.Contains(host, "[") && strings.Contains(host, "]") {
 			if at := strings.LastIndex(host, ":"); at != -1 {
-				p, err := strconv.ParseInt(host[at+1:], 10, 16)
+				p, err := strconv.ParseUint(host[at+1:], 10, 16)
 				if err != nil {
 					return "", "", 22, fmt.Errorf("failed to parse %s", hostname)
 				}

docs/changelog.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.12.1
+
+### Fixes
+
+- Fix port out of range when using shorthand format for hosts
+
 ## 0.12.0
 
 ### Features

docs/development.md

@@ -42,15 +42,15 @@ go run ../main.go run ping -a
 The following workflow is used for releasing a new `sake` version:
 
 1. Create pull request with changes
-2. Generate manpage
-   - `make gen-man`
-3. Pass all integration and unit tests locally
+2. Pass all integration and unit tests locally
    - `make integration-test`
    - `make unit-test`
-4. Run benchmarks and profiler to check performance
+3. Run benchmarks and profiler to check performance
    - `make benchmark`
-5. Verify build works (especially windows build)
+4. Verify build works (especially windows build)
    - `make build-all`
+5. Generate manpage
+   - `make gen-man`
 6. Update `Makefile` and `CHANGELOG.md` with correct version, and add all changes to `CHANGELOG.md`
 7. Squash-merge to main with `Release vx.y.z` and description of changes
 8. Run `make release`, which will: