build: migrate all ng_module in packages/core/test (angular#61472)

devversion · thePunderWoman · commit 082cc5579d4f · 2025-05-20T10:00:43.000Z
Migrates all `ng_module` to `ng_project` in `packages/core/test/`. PR Close angular#61472
diff --git a/packages/core/test/acceptance/BUILD.bazel b/packages/core/test/acceptance/BUILD.bazel
@@ -1,5 +1,5 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 
 package(default_visibility = ["//visibility:private"])
 
@@ -45,17 +45,17 @@ ts_project(
     ],
 )
 
-# Note: The `forward_ref` example tests are built through this `ng_module` sub-target.
+# Note: The `forward_ref` example tests are built through this `ng_project` sub-target.
 # This is done so that DI decorator/type metadata is processed manually by the compiler
 # ahead of time. We cannot rely on the official TypeScript decorator downlevel emit (for JIT),
 # as the output is not compatible with `forwardRef` and ES2015+. More details here:
 # https://github.com/angular/angular/commit/323651bd38909b0f4226bcb6c8f5abafa91cf9d9.
 # https://github.com/microsoft/TypeScript/issues/27519.
-ng_module(
+ng_project(
     name = "forward_ref_test_lib",
     testonly = True,
     srcs = SPEC_FILES_WITH_FORWARD_REFS,
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/core/testing",
     ],
diff --git a/packages/core/test/acceptance/authoring/BUILD.bazel b/packages/core/test/acceptance/authoring/BUILD.bazel
@@ -1,5 +1,5 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ng_module", "nodejs_binary", "npm_package_bin")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "nodejs_binary", "npm_package_bin")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 
 package(default_visibility = ["//visibility:private"])
 
@@ -8,14 +8,18 @@ TEST_FILES = glob(
     exclude = ["authoring_test_compiler.ts"],
 )
 
-TEST_DEPS = [
+TEST_INTEROP_DEPS = [
     "//packages/core",
     "//packages/core/rxjs-interop",
     "//packages/core/testing",
     "//packages/platform-browser",
     "//packages/core/primitives/signals",
 ]
 
+TEST_DEPS = [
+    "//:node_modules/rxjs",
+]
+
 ts_project(
     name = "test_compiler_lib",
     testonly = True,
@@ -55,21 +59,16 @@ ts_project(
     name = "test_jit_lib",
     testonly = True,
     srcs = ["transformed_%s" % file for file in TEST_FILES],
-    interop_deps = TEST_DEPS,
-    deps = [
-        # TODO: Only rely on `TEST_DEPS`. This should be removed during `rules_js` migration.
-        "//:node_modules/rxjs",
-    ],
+    interop_deps = TEST_INTEROP_DEPS,
+    deps = TEST_DEPS,
 )
 
-ng_module(
+ng_project(
     name = "test_lib",
     testonly = True,
     srcs = TEST_FILES,
-    deps = TEST_DEPS + [
-        # TODO: Only rely on `TEST_DEPS`. This should be removed during `rules_js` migration.
-        "@npm//rxjs",
-    ],
+    interop_deps = TEST_INTEROP_DEPS,
+    deps = TEST_DEPS,
 )
 
 jasmine_node_test(
diff --git a/packages/core/test/acceptance/selectorless/BUILD b/packages/core/test/acceptance/selectorless/BUILD
@@ -1,18 +1,20 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ng_module")
+load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:private"])
 
-ng_module(
+ng_project(
     name = "selectorless_test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
-    tsconfig = ":tsconfig.json",
-    visibility = ["//:__pkg__"],
-    deps = [
+    extends = "//packages/core:tsconfig_test",
+    interop_deps = [
         "//packages/core",
         "//packages/core/testing",
         "//packages/zone.js/lib:zone_d_ts",
     ],
+    tsconfig = ":tsconfig.json",
+    visibility = ["//:__pkg__"],
 )
 
 jasmine_node_test(
diff --git a/packages/core/test/acceptance/selectorless/tsconfig.json b/packages/core/test/acceptance/selectorless/tsconfig.json
@@ -1,17 +1,10 @@
 {
+  "extends": "../../../tsconfig-test.json",
   "compilerOptions": {
-    "strict": true,
-    "types": ["node", "jasmine"],
-    "plugins": [{
-      "name": "@bazel/tsetse",
-      "disabledRules": ["must-use-promises"]
-    }]
+    "strict": true
   },
   "angularCompilerOptions": {
     "strictTemplates": true,
     "_enableSelectorless": true
-  },
-  "bazelOptions": {
-    "suppressTsconfigOverrideWarnings": true
   }
 }
diff --git a/packages/core/test/bundling/animations-standalone/BUILD.bazel b/packages/core/test/bundling/animations-standalone/BUILD.bazel
@@ -1,14 +1,14 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "animations_standalone",
     srcs = ["index.ts"],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
         "//packages/platform-browser/animations",
diff --git a/packages/core/test/bundling/cyclic_import/BUILD.bazel b/packages/core/test/bundling/cyclic_import/BUILD.bazel
@@ -1,16 +1,16 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "cyclic_import",
     srcs = [
         "index.ts",
         "trigger.ts",
     ],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
     ],
diff --git a/packages/core/test/bundling/defer/BUILD.bazel b/packages/core/test/bundling/defer/BUILD.bazel
@@ -1,17 +1,17 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "defer",
     srcs = [
         "defer.component.ts",
         "index.ts",
     ],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
     ],
diff --git a/packages/core/test/bundling/forms_reactive/BUILD.bazel b/packages/core/test/bundling/forms_reactive/BUILD.bazel
@@ -1,14 +1,14 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "forms_reactive",
     srcs = ["index.ts"],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/forms",
         "//packages/platform-browser",
diff --git a/packages/core/test/bundling/forms_template_driven/BUILD.bazel b/packages/core/test/bundling/forms_template_driven/BUILD.bazel
@@ -1,14 +1,14 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "forms_template_driven",
     srcs = ["index.ts"],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/forms",
         "//packages/platform-browser",
diff --git a/packages/core/test/bundling/hydration/BUILD.bazel b/packages/core/test/bundling/hydration/BUILD.bazel
@@ -1,14 +1,14 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "hydration",
     srcs = ["index.ts"],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
     ],
diff --git a/packages/core/test/bundling/image-directive/BUILD.bazel b/packages/core/test/bundling/image-directive/BUILD.bazel
@@ -1,9 +1,9 @@
-load("//tools:defaults.bzl", "esbuild", "http_server", "ng_module", "protractor_web_test_suite")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "esbuild", "http_server", "protractor_web_test_suite")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "image-directive",
     srcs = [
         "e2e/basic/basic.ts",
@@ -18,7 +18,7 @@ ng_module(
         "index.ts",
         "playground.ts",
     ],
-    deps = [
+    interop_deps = [
         "//packages/common",
         "//packages/core",
         "//packages/platform-browser",
diff --git a/packages/core/test/bundling/router/BUILD.bazel b/packages/core/test/bundling/router/BUILD.bazel
@@ -1,15 +1,15 @@
-load("//tools:defaults.bzl", "app_bundle", "http_server", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "http_server", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "router",
     srcs = [
         "index.ts",
     ],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
         "//packages/router",
diff --git a/packages/core/test/bundling/router/index.ts b/packages/core/test/bundling/router/index.ts
@@ -11,6 +11,7 @@ import {Component, OnInit} from '../../../src/core';
 import {bootstrapApplication} from '@angular/platform-browser';
 import {
   ActivatedRoute,
+  ParamMap,
   provideRouter,
   Router,
   RouterLink,
@@ -48,7 +49,7 @@ class ItemComponent implements OnInit {
   ) {}
 
   ngOnInit() {
-    this.activatedRoute.paramMap.subscribe((paramsMap) => {
+    this.activatedRoute.paramMap.subscribe((paramsMap: ParamMap) => {
       this.id = +paramsMap.get('id')!;
     });
   }
diff --git a/packages/core/test/bundling/standalone_bootstrap/BUILD.bazel b/packages/core/test/bundling/standalone_bootstrap/BUILD.bazel
@@ -1,14 +1,14 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test", "ng_module")
-load("//tools:defaults2.bzl", "ts_project")
+load("//tools:defaults.bzl", "app_bundle", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ng_project", "ts_project")
 load("//tools/symbol-extractor:index.bzl", "js_expected_symbol_test")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "standalone_bootstrap",
     srcs = ["index.ts"],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
     ],
diff --git a/packages/core/test/playground/zone-signal-input/BUILD.bazel b/packages/core/test/playground/zone-signal-input/BUILD.bazel
@@ -1,14 +1,15 @@
-load("//tools:defaults.bzl", "app_bundle", "http_server", "ng_module")
+load("//tools:defaults.bzl", "app_bundle", "http_server")
+load("//tools:defaults2.bzl", "ng_project")
 
-ng_module(
+ng_project(
     name = "test_lib",
     srcs = ["index.ts"],
-    tags = ["no-cache"],
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/platform-browser",
         "//packages/zone.js/lib",
     ],
+    tags = ["no-cache"],
 )
 
 filegroup(
diff --git a/packages/core/test/resource/BUILD.bazel b/packages/core/test/resource/BUILD.bazel
@@ -1,14 +1,15 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ng_module")
+load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:private"])
 
-ng_module(
+ng_project(
     name = "resource_lib",
     testonly = True,
     srcs = glob(
         ["**/*.ts"],
     ),
-    deps = [
+    interop_deps = [
         "//packages/core",
         "//packages/core/testing",
     ],
diff --git a/packages/core/test/resource/resource_spec.ts b/packages/core/test/resource/resource_spec.ts
@@ -17,6 +17,9 @@ import {
 } from '../../src/core';
 import {TestBed} from '../../testing';
 
+// Needed for the `Promise.withResolvers()` usage below.
+import '../../src/util/promise_with_resolvers';
+
 abstract class MockBackend<T, R> {
   protected pending = new Map<
     T,
diff --git a/packages/core/test/strict_types/BUILD.bazel b/packages/core/test/strict_types/BUILD.bazel
@@ -17,7 +17,7 @@ ts_project(
     srcs = glob(
         ["**/*.ts"],
     ),
-    extends = "//packages:tsconfig_test",
+    extends = "//packages/core:tsconfig_test",
     tsconfig = ":tsconfig",
     deps = [
         "//packages/core:core_rjs",
diff --git a/packages/core/test/strict_types/tsconfig.json b/packages/core/test/strict_types/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../../../tsconfig-test.json",
+  "extends": "../../tsconfig-test.json",
   "compilerOptions": {
     "strict": true
   }
