Merge pull request #149 from matthew-hennefarth/fix-build-pedantic

Fix -DBUILD_WITH_PEDANTIC_WARNINGS=ON

Author: alandefreitas

CMakeLists.txt

@@ -33,6 +33,9 @@ else()
     set(NOT_DEBUG_MODE ON)
 endif()
 
+# Function to link external libraries as system libraries
+include (cmake/LinkExternalLibraries.cmake)
+
 #######################################################
 ### Options                                         ###
 #######################################################

cmake/LinkExternalLibraries.cmake

@@ -0,0 +1,28 @@
+function(target_link_libraries_system target)
+  set(options PRIVATE PUBLIC INTERFACE)
+  cmake_parse_arguments(TLLS "${options}" "" "" ${ARGN})
+  foreach(op ${options})
+    if(TLLS_${op})
+      set(scope ${op})
+    endif()
+  endforeach(op)
+  set(libs ${TLLS_UNPARSED_ARGUMENTS})
+
+  foreach(lib ${libs})
+    get_target_property(lib_include_dirs ${lib} INTERFACE_INCLUDE_DIRECTORIES)
+    if(lib_include_dirs)
+      if(scope)
+        target_include_directories(${target} SYSTEM ${scope} ${lib_include_dirs})
+      else()
+        target_include_directories(${target} SYSTEM PRIVATE ${lib_include_dirs})
+      endif()
+    else()
+      message("Warning: ${lib} doesn't set INTERFACE_INCLUDE_DIRECTORIES. No include_directories set.")
+    endif()
+    if(scope)
+      target_link_libraries(${target} ${scope} ${lib})
+    else()
+      target_link_libraries(${target} ${lib})
+    endif()
+  endforeach()
+endfunction(target_link_libraries_system)

source/matplot/CMakeLists.txt

@@ -90,8 +90,8 @@ target_include_directories(matplot
     PUBLIC $<BUILD_INTERFACE:${MATPLOT_ROOT_DIR}/source>
            $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)
 
-target_link_libraries(matplot
-    PRIVATE cimg nodesoup std::filesystem)
+target_link_libraries_system(matplot 
+  PRIVATE cimg nodesoup std::filesystem)
 
 # https://cmake.org/cmake/help/v3.14/manual/cmake-compile-features.7.html#requiring-language-standards
 target_compile_features(matplot PUBLIC cxx_std_17)
@@ -242,4 +242,4 @@ if (BUILD_INSTALLER)
             NAMESPACE Matplot++::
             DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/Matplot++
             )
-endif()
+endif()