Put O2 in build workflow

Author: alandefreitas

.github/workflows/build.yml

@@ -41,23 +41,23 @@ jobs:
             name: "Windows/2019/Static/X64/Release",
             os: windows-2019,
             config: Release,
-            cmake_extra_args: -G "Visual Studio 16 2019" -A x64,
+            cmake_extra_args: -G "Visual Studio 16 2019" -A x64 -DCMAKE_CXX_FLAGS="/O2",
             sudocmd: "",
             artifact_name: "Windows x64",
           }
           - {
             name: "Ubuntu/18.04/Static/X64/Release",
             os: ubuntu-18.04,
             config: Release,
-            cmake_extra_args: "-DCMAKE_C_COMPILER=/usr/bin/gcc-8 -DCMAKE_CXX_COMPILER=/usr/bin/g++-8",
+            cmake_extra_args: "-DCMAKE_C_COMPILER=/usr/bin/gcc-8 -DCMAKE_CXX_COMPILER=/usr/bin/g++-8  -DCMAKE_CXX_FLAGS=\"-O2\"",
             sudocmd: "sudo",
             artifact_name: "Linux",
           }
           - {
             name: "MacOSX/10.15/Static/X64/Release",
             os: macos-10.15,
             config: Release,
-            cmake_extra_args: "",
+            cmake_extra_args: "-DCMAKE_CXX_FLAGS=\"-O2\"",
             sudocmd: "sudo",
             artifact_name: "MacOSX",
           }

CMakeLists.txt

@@ -38,18 +38,9 @@ option(BUILD_SHARED_LIBS "Build shared libraries" OFF)
 option(BUILD_HIGH_RESOLUTION_WORLD_MAP "Compile the high resolution maps for geoplots" ON)
 option(BUILD_FOR_DOCUMENTATION_IMAGES "Bypass wait() commands and save figures as .svg at destruction" OFF)
 option(BUILD_EXPERIMENTAL_OPENGL_BACKEND "Compile target with the experimental OpenGL backend" OFF)
-option(OPTIMIZE_RELEASE_CODE_BY_DEFAULT "Turn on optimization flags by default in Release" OFF)
 option(BUILD_WITH_PEDANTIC_WARNINGS "Use pedantic warnings. This is useful for developers because many of these warnings will be in continuous integration anyway." OFF)
 option(BUILD_WITH_UTF8 "Accept utf-8 in MSVC by default." ON)
 
-if (OPTIMIZE_RELEASE_CODE_BY_DEFAULT)
-    if (MSVC)
-        set(CMAKE_CXX_FLAGS_RELEASE "/O2")
-    else ()
-        set(CMAKE_CXX_FLAGS_RELEASE "-O2")
-    endif ()
-endif ()
-
 # Where to find dependencies
 option(WITH_SYSTEM_CIMG "Use system-provided CImg.h instead of bundled" OFF)
 option(WITH_SYSTEM_NODESOUP "Use system-provided nodesoup instead of bundled" OFF)